Review main Merged

84870[TASK] Allow additional composer options for `-s composerInstall`

Stefan Bürk CR +2 V +2 Easy +2 −1 updated 06/25/24, 08:54

Commit message

This change modifies the `Build/Script/runTests.sh`
command dispatcher to allow passing composer options
to the `composer install` subcommand, for example

  Build/Scripts/runTests.sh -s composerInstall \
    -- --prefer-source

Note that this is already possible using the generic
`-s composer` dispatcher but would resolve some user
confusion.

This is useful to install dependencies as git
checkouts, for example when working on packages
like `typo3/testing-framework` changes. Albeit
the need to remove the vendor folder first is
needed in case of the example.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Stefan Bürk uploaded patch set 1 06/23/24, 16:15

  2. core-ci voted on patch set 1 V +1 06/23/24, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60124

  3. Oliver Klee updated the commit message in patch set 2 V +1 06/23/24, 16:49

  4. core-ci voted on patch set 2 V +1 06/23/24, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60125

  5. Benni Mack voted on patch set 2 CR +1 V +1 06/25/24, 06:53

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 06/25/24, 08:42

  7. Stefan Bürk voted on patch set 2 CR +2 V +2 06/25/24, 08:42

  8. Stefan Bürk merged patch set 3 06/25/24, 08:54