Review main Merged

84873[TASK] Avoid implicitly nullable class method parameter in `EXT:webhooks`

Stefan Bürk CR +2 V +2 Easy +5 −5 updated 06/24/24, 12:28

Commit message

With PHP 8.4 marking method parameter implicitly nullable
is deprecated and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator. [1]

This prepares the way towards PHP 8.4 compatibility.

[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Stefan Bürk uploaded patch set 1 06/23/24, 21:25

  2. core-ci voted on patch set 1 V +1 06/23/24, 21:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60129

  3. Stefan Bürk updated the commit message in patch set 2 V +1 06/23/24, 21:40

  4. core-ci voted on patch set 2 V +1 06/23/24, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60134

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 06/23/24, 22:10

  6. Benni Mack updated the commit message in patch set 3 CR +1 V +1 06/24/24, 06:38

  7. core-ci voted on patch set 3 V +1 06/24/24, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60153

  8. Garvin Hicking voted on patch set 3 CR +1 V +1 06/24/24, 07:01

  9. Oli Bartsch voted on patch set 3 CR +1 V +1 06/24/24, 07:48

  10. Oliver Klee voted on patch set 3 CR +1 V +1 06/24/24, 09:53

  11. Stefan Bürk voted on patch set 3 CR +2 V +2 06/24/24, 12:28

  12. Stefan Bürk merged patch set 4 06/24/24, 12:28