84880[BUGFIX] Apply configured date format to date(time) fields
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 3
Files 6
- typo3/sysext/backend/Classes/Controller/BackendController.php+7 −1
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php+1 −1
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php4+5 −1
- typo3/sysext/backend/Tests/Unit/Form/Element/AbstractFormElementTest.php+1 −1
- typo3/sysext/core/Classes/Localization/DateFormatter.php+68 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputDateCest.php+12 −12
Review log 1825
-
Benni Mack uploaded patch set 1 06/24/24, 11:39
-
core-ci voted on patch set 1 V -1 06/24/24, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60170
-
Benjamin Franzke uploaded patch set 2
V -107/12/24, 16:35 -
Benjamin Franzke commented on patch set 2 07/12/24, 16:39
-
core-ci voted on patch set 2 V -1 07/12/24, 16:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61499
-
Benjamin Franzke uploaded patch set 3
V -107/12/24, 18:05 -
core-ci voted on patch set 3 V -1 07/12/24, 18:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61504
-
Benjamin Franzke uploaded patch set 4
V -107/12/24, 18:11 -
core-ci voted on patch set 4 V +1 07/12/24, 18:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61505
-
Benjamin Franzke uploaded patch set 5
V +107/12/24, 19:06 -
core-ci voted on patch set 5 V +1 07/12/24, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61507
-
Andreas Kienast uploaded patch set 6
V +108/09/24, 08:41 -
core-ci voted on patch set 6 V +1 08/09/24, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63117
-
Garvin Hicking commented on patch set 6 08/09/24, 10:11
FormResultCompiler.php:183Replypersonally I prefer the backend in english, but I hate the default date representation there. So, as a user, I would probably like to pick a "date locale" different than a "language locale" (like OS's allow to configure). -
Benjamin Franzke commented on patch set 6 08/09/24, 11:55
FormResultCompiler.php:183ReplyAck, that'd be an additional FEATURE to support sth like `LC_TIME` on a per-user basis. FYI: The initial support for date-locale handling (so an alternative to this patch) would look like: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85262 (It has it's own limitations: date presets are not very flexible and there is no way to parse a generated string back into a date object, that means it's not usable for a manually editable datepicker) Still I'd think that would be the better approach, as forcing `TYPO3_CONF_VARS/SYS/ddmmyy` to all users is really only an improvement if all editors have the same language/time-preference. -
Andreas Kienast voted on patch set 6 CR +1 V +1 08/12/24, 06:28
-
Andreas Kienast commented on patch set 6 V 0 CR -1 08/12/24, 07:17
Will be merged after the next 12.4 release -
Benjamin Franzke commented on patch set 6 08/12/24, 07:18
FormResultCompiler.php:183ReplyI will skip this topic for now, respecting `TYPO3_CONF_VARS/SYS/ddmmyy` is perfectly fine for 12.4 -
Andreas Kienast uploaded patch set 7
CR -1V +108/16/24, 07:46 -
core-ci voted on patch set 7 V +1 08/16/24, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63554
-
Andreas Kienast voted on patch set 7 CR +1 V +1 08/16/24, 07:56
-
Simon Schaufelberger voted on patch set 7 CR +1 V +1 08/23/24, 12:26
-
Benjamin Franzke voted on patch set 7 CR +1 V +1 08/23/24, 13:26
-
Andreas Kienast voted on patch set 7 CR +2 V +2 08/23/24, 13:27
-
Andreas Kienast merged patch set 8 08/23/24, 13:27
FormResultCompiler.php:183