Review 12.4 Merged

84887[TASK] Avoid implicitly nullable class method parameter in `EXT:seo`

Stefan Bürk CR +2 V +2 Easy +6 −6 updated 06/25/24, 08:14

Commit message

With PHP 8.4 marking method parameter implicitly nullable
is deprecated and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator. [1]

This prepares the way towards PHP 8.4 compatibility.

[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Fabien Udriot +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 56

  1. Stefan Bürk uploaded patch set 1 06/24/24, 14:19

  2. core-ci voted on patch set 1 V +1 06/24/24, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60188

  3. Fabien Udriot voted on patch set 1 CR +1 06/25/24, 06:45

  4. Oliver Klee voted on patch set 1 CR +1 V +1 06/25/24, 07:01

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 06/25/24, 08:14

  6. Stefan Bürk merged patch set 2 06/25/24, 08:14