Review main Merged

84890[TASK] Remove duplicated code from typo3-backend-icon component

Marcin Sągol CR +2 V +2 Easy +0 −6 updated 06/24/24, 15:35

Commit message

The `typo3-backend-icon` component code contains a duplicated
code fragment. This patch removes one occurrence.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Marcin Sągol uploaded patch set 1 06/24/24, 15:13

  2. Oli Bartsch voted on patch set 1 CR +1 V +1 06/24/24, 15:17

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 06/24/24, 15:18

  4. core-ci voted on patch set 1 V -1 06/24/24, 15:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60192

  5. core-ci voted on patch set 1 V +1 06/24/24, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60192

  6. Andreas Kienast voted on patch set 1 CR +2 V +2 06/24/24, 15:25

  7. Andreas Kienast merged patch set 2 06/24/24, 15:35