Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
84892[TASK] Merge Permissions and Backend Users modules
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 12
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/92/84892/12 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/92/84892/12 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- Oli Bartsch -1
- Riccardo De Contardi +1
- core-ci +1 CI
Issues 1
Files 32
- Build/tests/playwright/e2e/records/record-download-with-preset.spec.ts+1 −6
- Build/tests/playwright/e2e/users/users-module.spec.ts+3 −14
- typo3/sysext/backend/Classes/Controller/SwitchUserController.php+1 −1
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+2 −2
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+52 −119
- typo3/sysext/beuser/Classes/Controller/PermissionController.php1+7 −5
- typo3/sysext/beuser/Classes/Upgrades/AccessModuleBookmarksMigration.phpnew+153 −0
- typo3/sysext/beuser/Configuration/Backend/AjaxRoutes.php+1 −1
- typo3/sysext/beuser/Configuration/Backend/Modules.php2+72 −21
- typo3/sysext/beuser/Configuration/Icons.phpnew+28 −0
- typo3/sysext/beuser/Resources/Private/Language/Modules/access.xlfnew+17 −0
- typo3/sysext/beuser/Resources/Private/Language/Modules/filemounts.xlfnew+17 −0
- typo3/sysext/beuser/Resources/Private/Language/Modules/groups.xlfnew+17 −0
- typo3/sysext/beuser/Resources/Private/Language/Modules/online.xlfnew+17 −0
- typo3/sysext/beuser/Resources/Private/Language/Modules/permissions.xlf+3 −3
- typo3/sysext/beuser/Resources/Private/Language/Modules/users.xlfnew+17 −0
- typo3/sysext/beuser/Resources/Private/Language/Modules/user_management.xlfdeleted+0 −17
- typo3/sysext/beuser/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/beuser/Resources/Private/Templates/Filemount/List.fluid.html+1 −1
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Index.fluid.html+1 −1
Show 12 more files
- typo3/sysext/beuser/Resources/Public/Icons/module-access-filemounts.svgnew+1 −0
- typo3/sysext/beuser/Resources/Public/Icons/module-access-groups.svgnew+1 −0
- typo3/sysext/beuser/Resources/Public/Icons/module-access-online.svgnew+1 −0
- typo3/sysext/beuser/Resources/Public/Icons/module-access-pages.svgnew+1 −0
- typo3/sysext/beuser/Resources/Public/Icons/module-access-users.svgnew+1 −0
- typo3/sysext/beuser/Tests/Functional/Controller/BackendUserControllerTest.php+7 −7
- typo3/sysext/beuser/Tests/Functional/Upgrades/Fixtures/AccessModuleBookmarksBase.csvnew+13 −0
- typo3/sysext/beuser/Tests/Functional/Upgrades/Fixtures/AccessModuleBookmarksMigrated.csvnew+13 −0
- typo3/sysext/beuser/Tests/Functional/Upgrades/AccessModuleBookmarksMigrationTest.phpnew+47 −0
- typo3/sysext/core/Configuration/Backend/Modules.php+1 −1
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-84892-PermissionsAndBackendUsersModulesMergedIntoAccessModule.rstnew+85 −0
- typo3/sysext/scheduler/Configuration/Backend/Modules.php+1 −1
Review log 2133
Show 48 earlier messages
-
Marcin Sągol uploaded patch set 1 06/25/24, 06:45
-
core-ci voted on patch set 1 V -1 06/25/24, 06:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60263
-
Marcin Sągol uploaded patch set 2
V -106/25/24, 07:03 -
Marcin Sągol uploaded patch set 3 06/25/24, 07:09
-
core-ci voted on patch set 2 V -1 06/25/24, 07:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60264
-
core-ci voted on patch set 3 V -1 06/25/24, 07:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60265
-
Marcin Sągol uploaded patch set 4
V -106/25/24, 07:23 -
core-ci voted on patch set 4 V -1 06/25/24, 07:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60266
-
Marcin Sągol uploaded patch set 5
V -106/30/24, 14:37 -
core-ci voted on patch set 5 V -1 06/30/24, 15:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60694
-
Marcin Sągol uploaded patch set 6
V -106/30/24, 18:59 -
core-ci voted on patch set 6 V -1 06/30/24, 19:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60705
-
Marcin Sągol uploaded patch set 7
V -106/30/24, 19:05 -
core-ci voted on patch set 7 V +1 06/30/24, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60706
-
Oskar Dydo uploaded patch set 8
V +109/04/24, 22:04 -
Oskar Dydo uploaded patch set 9 09/04/24, 22:06
-
core-ci voted on patch set 8 V +1 09/04/24, 22:16 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 9 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64818
-
core-ci voted on patch set 9 V +1 09/04/24, 22:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64820
-
Guido Schmechel voted on patch set 9 CR +1 V +1 09/07/24, 17:00
-
Markus Klein commented on patch set 10
CR +1V +109/13/24, 17:34Published edit on patch set 9. -
Markus Klein voted on patch set 10 CR +1 09/13/24, 17:37
-
core-ci voted on patch set 10 V +1 09/13/24, 17:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65702
-
Stefan Bürk commented on patch set 10 CR -1 09/13/24, 23:53
PermissionController.php:405UnresolvedThis controller is not extbase based. Don't introduce the extbase localization utility here. Use the core language service instead, please. ``` $lang = $this->getLanguageService(); $lang->sL('LLL:....'); ``` Same for usage below in this method.Modules.php:20UnresolvedIt's kind of confusing now - can we move the permissions_pages after the backend_user_management block please ?Modules.php:32UnresolvedI'd say we should keep that aliasmodule-users-and-permissions.svg:1UnresolvedNot sure, but I guess this svg should be added to the TYPO3 Icon Pack and updated within the core: * https://typo3.github.io/TYPO3.Icons/icons/module.html * https://github.com/typo3/typo3.icons * https://github.com/TYPO3/typo3/blob/e906a4a68ffd061fa92943bfa9e933e60a405e57/Build/package.json#L152 Maybe @benjamin.kott@outlook.com @a.fernandez@scripting-base.de can say more to core module icons. -
Benni Mack commented on patch set 10 05/06/26, 09:03
anyone up for rebasing this change for v15? Otherwise I'd abandon it. there hasn't been a lot of activity. -
Marcin Sągol commented on patch set 10 05/11/26, 07:57
Reply Unresolved
@benni@typo3.org I will take car of it, so please do not close it. -
Marcin Sągol uploaded patch set 11
CR +1V +108/06/26, 16:46 -
core-ci voted on patch set 11 V -1 08/06/26, 16:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106008
-
Marcin Sągol uploaded patch set 12
V -108/06/26, 17:04 -
core-ci voted on patch set 12 V +1 08/06/26, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106010
-
Riccardo De Contardi commented on patch set 12 08/06/26, 21:01
I think I already said somewhere: is the submodule "Online users" really necessary? Can't be merged with the "Users" submodule? I see in the latter one a "pulsating" green dot that should indicate that the user is online... IDK if it is a good idea, as this kind of notification is difficult to understand and if I am not wrong this metaphor is not used elsewhere on the backend -
Marcin Sągol commented on patch set 12 08/06/26, 21:59
Reply
Agree, I would merge Users and Online Users modules but as a separate patch. First this one, and if accepted the mentioned merge as a follow-uo. -
Riccardo De Contardi voted on patch set 12 V +1 08/07/26, 08:07
-
Oli Bartsch commented on patch set 12 V -1 11/10/26, 14:00
Unresolved
I don't think we should merge this, and I'd actually suggest abandoning it. The module structure was deliberately reorganised in v14 (#107628). Administration was redefined as the place for "user and permission management, the Scheduler, and Integrations", Users was moved to the top of it, and the changelog promised that backend_user_management stays unchanged. Since then the module menu and icons have been iterated on along that structure. This patch adds a seventh top-level group just one major later and takes the stated core content out of Administration again. That works against the current direction rather than building on it. The user-facing benefit is small. The views can already be switched from the docheader, every view can already be bookmarked with its action, and the module remembers the last view. What we would get in exchange: a second rename of the identifiers in consecutive majors, Extbase routes (backend_user_management.BackendUser_<action>) dropped without alias, a changed module path, lost module data, third-party submodules silently moving one level down, and an upgrade wizard. On top, "Online users" ships as its own submodule although we already agreed to merge it into "Users" (it overlaps with the "Current logged-in users" filter from #107953), and "Pages" as a module name brings back the ambiguity v14 removed when renaming Page to Layout. The part worth keeping is replacing the custom addMainMenu() and the defaultAction handling with the core docheader module menu and breadcrumb nodes. That can be done in place, within Administration, e.g. as submodules of the existing module or with a submodule overview, without new top-level groups, identifiers or wizards. If you want to pursue that, I think a new issue and patch should be added for it.