Review main Merged

84898[TASK] Avoid implicitly nullable class method parameter in `EXT:scheduler`

Stefan Bürk CR +2 V +2 Easy +4 −4 updated 06/25/24, 12:40

Commit message

With PHP 8.4 marking method parameter implicitly nullable
is deprecated and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator. [1]

In case of union type the null is added as additional type.

This prepares the way towards PHP 8.4 compatibility.

[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Stefan Bürk uploaded patch set 1 06/25/24, 11:38

  2. core-ci voted on patch set 1 V +1 06/25/24, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60286

  3. Georg Ringer voted on patch set 1 CR +1 V +1 06/25/24, 12:10

  4. Benni Mack voted on patch set 1 CR +1 V +1 06/25/24, 12:17

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 06/25/24, 12:39

  6. Stefan Bürk merged patch set 2 06/25/24, 12:40