Review main Merged

84910[BUGFIX] Add `name` attribute to readonly fields in FormEngine

Oli Bartsch CR +2 V +2 Easy +21 −20 updated 06/28/24, 09:03

Commit message

Some FormEngine related JS components, e.g. the
slug element rely on input and text fields to
have the field name set via either the special
`data-formengine-input-name` - if pointing to
a hidden input field - or via the standard
`name` attribute.

All those FormEngine elements support the
readonly state, which renders only the field
with the `disabled` attribute set by omitting
any JS functionality. For this use case no
`name` attribute is required. However, to use
them in combination with other fields, e.g.
as generator field for TCA type slug, the
field name is now added as `name` attribute
in readonly state.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 68

  1. Oli Bartsch uploaded patch set 1 06/25/24, 13:48

  2. Oli Bartsch updated the commit message in patch set 2 06/25/24, 13:49

  3. core-ci voted on patch set 2 V +1 06/25/24, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60307

  4. core-ci voted on patch set 1 V +1 06/25/24, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60306

  5. Georg Ringer voted on patch set 2 CR +1 V +1 06/26/24, 03:54

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 06/28/24, 08:28

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 06/28/24, 09:03

  8. Oli Bartsch merged patch set 3 06/28/24, 09:03