Review main Merged

84913[TASK] Provide PSR-7 Request in PolicyMutatedEvent

Oli Bartsch CR +2 V +2 Easy +18 −14 updated 06/26/24, 15:42

Commit message

For additional context does the PolicyMutatedEvent
now provide the current PSR-7 Request.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 911

  1. Oli Bartsch uploaded patch set 1 06/25/24, 14:53

  2. core-ci voted on patch set 1 V -1 06/25/24, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60311

  3. Oli Bartsch uploaded patch set 2 V -1 06/25/24, 16:00

  4. core-ci voted on patch set 2 V +1 06/25/24, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60312

  5. Georg Ringer voted on patch set 2 CR +1 V +1 06/25/24, 17:20

  6. Benni Mack voted on patch set 2 CR +1 V +1 06/26/24, 05:26

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 06/26/24, 08:45

  8. Oli Bartsch merged patch set 3 06/26/24, 08:45

  9. Oliver Hader commented on patch set 3 06/26/24, 10:48

    CspAjaxController.php:117 Unresolved

    This does not seem to be correct. This is the request in the backend backend module for fetching all previous reports - the request is irrelevant for CSP in that scope and that event...
  10. Oliver Hader commented on patch set 3 06/26/24, 12:44

    Post -1 as it seems to be incorrect and contains API changes that are not relevant (e.g. the AJAX part)
  11. Oli Bartsch commented on patch set 3 06/26/24, 15:42

    Reply Unresolved

    Please see a followup, removing the usage in the ajax controller: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84930