Review main Merged

84915[TASK] Avoid implicitly nullable class method parameter in `EXT:linkvalidator`

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 06/26/24, 16:04

Commit message

With PHP 8.4 marking method parameter implicitly nullable
is deprecated and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator or adding a null
tyype to an union type definition. [1]

This prepares the way towards PHP 8.4 compatibility.

[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Stefan Bürk uploaded patch set 1 06/25/24, 17:18

  2. core-ci voted on patch set 1 V +1 06/25/24, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60314

  3. Georg Ringer voted on patch set 1 CR +1 V +1 06/25/24, 19:40

  4. core-ci voted on patch set 1 V -1 06/26/24, 10:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60369

  5. Oliver Klee voted on patch set 1 CR +1 V +1 06/26/24, 13:03

  6. Stefan Bürk rebased onto patch set 2 CR +1 V +1 06/26/24, 13:10

  7. core-ci voted on patch set 2 V +1 06/26/24, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60388

  8. Georg Ringer voted on patch set 2 CR +1 V +1 06/26/24, 14:11

  9. Christian Kuhn voted on patch set 2 CR +1 V +1 06/26/24, 15:09

  10. Stefan Bürk voted on patch set 2 CR +2 V +2 06/26/24, 16:04

  11. Stefan Bürk merged patch set 3 06/26/24, 16:04