Review main Merged

84921[DOCS] Document YAML configuration options for Link Browser in CKEditor

Garvin Hicking CR +2 V +2 Hard +377 −0 updated 06/27/24, 20:27

Commit message

The CKEditor YAML files support a lot of configuration
options to adjust the Link Browser appearance, adding additional
CSS class selection, link-target selection, title attribute
and others.

The Link Browser configuration is mostly revealed through TCA
configuration, but the YAML format was not documented yet.

The documentation is updated to reflect all configuration options,
and an example YAML file
`EXT:rte_ckeditor/Configuration/RTE/Editor/LinkBrowser.yaml` has
been added.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Torben Hansen +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Torben Hansen +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1114

  1. Garvin Hicking uploaded patch set 1 06/25/24, 20:51

  2. core-ci voted on patch set 1 V +1 06/25/24, 20:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60322

  3. Garvin Hicking commented on patch set 1 06/25/24, 21:09

    (I'll adjust the commit message after a good night's sleep of course, hope no one feels offended ;) )
  4. Torben Hansen commented on patch set 1 06/26/24, 17:53

    LinkBrowser.yaml:48

    Lets remove this ;-)

    LinkBrowser.yaml:90

    Is this the `value` property (see below) youm refer to? If yes and if it is deprecated/does not work in all browsers, I think it is better to remove it from the config.

    Reference.rst:368

    Same as previous comment: If this does not work in all browsers or is deprecated, I think it is better to leave out the part about styling.
  5. Garvin Hicking uploaded patch set 2 V +1 06/27/24, 06:07

    Remain objective
  6. Garvin Hicking commented on patch set 2 06/27/24, 06:08

    LinkBrowser.yaml:48 Reply

    Done

    LinkBrowser.yaml:90 Reply

    Yes. Since removing it would be breaking I would rather at this point like to document it, and a deprecation should be a follow-up/seperate PR.

    Reference.rst:368 Reply

    Acknowledged
  7. core-ci voted on patch set 2 V +1 06/27/24, 06:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60436

  8. Garvin Hicking updated the commit message in patch set 3 V +1 06/27/24, 06:14

    Relate another ticket
  9. core-ci voted on patch set 3 V +1 06/27/24, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60437

  10. Georg Ringer voted on patch set 3 CR +1 V +1 06/27/24, 12:02

  11. Torben Hansen voted on patch set 3 CR +1 V +1 06/27/24, 12:31

  12. Lina Wolf commented on patch set 3 CR +1 V +1 06/27/24, 15:07

    Looks good to me
  13. Stefan Bürk voted on patch set 3 CR +2 V +2 06/27/24, 20:20

  14. Stefan Bürk merged patch set 4 06/27/24, 20:27