84921[DOCS] Document YAML configuration options for Link Browser in CKEditor
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Torben Hansen +1
- Lina Wolf +1
-
Verified V +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Torben Hansen +1
- Lina Wolf +1
- core-ci +1 CI
Issues 2
Files 4
Review log 1114
-
Garvin Hicking uploaded patch set 1 06/25/24, 20:51
-
core-ci voted on patch set 1 V +1 06/25/24, 20:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60322
-
Garvin Hicking commented on patch set 1 06/25/24, 21:09
(I'll adjust the commit message after a good night's sleep of course, hope no one feels offended ;) ) -
Torben Hansen commented on patch set 1 06/26/24, 17:53
LinkBrowser.yaml:48Lets remove this ;-)LinkBrowser.yaml:90Is this the `value` property (see below) youm refer to? If yes and if it is deprecated/does not work in all browsers, I think it is better to remove it from the config.Reference.rst:368Same as previous comment: If this does not work in all browsers or is deprecated, I think it is better to leave out the part about styling. -
Garvin Hicking uploaded patch set 2
V +106/27/24, 06:07Remain objective -
Garvin Hicking commented on patch set 2 06/27/24, 06:08
LinkBrowser.yaml:48ReplyDoneLinkBrowser.yaml:90ReplyYes. Since removing it would be breaking I would rather at this point like to document it, and a deprecation should be a follow-up/seperate PR.Reference.rst:368ReplyAcknowledged -
core-ci voted on patch set 2 V +1 06/27/24, 06:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60436
-
Garvin Hicking updated the commit message in patch set 3
V +106/27/24, 06:14Relate another ticket -
core-ci voted on patch set 3 V +1 06/27/24, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60437
-
Georg Ringer voted on patch set 3 CR +1 V +1 06/27/24, 12:02
-
Torben Hansen voted on patch set 3 CR +1 V +1 06/27/24, 12:31
-
Lina Wolf commented on patch set 3 CR +1 V +1 06/27/24, 15:07
Looks good to me -
Stefan Bürk voted on patch set 3 CR +2 V +2 06/27/24, 20:20
-
Stefan Bürk merged patch set 4 06/27/24, 20:27