Review 12.4 Merged

84922[TASK] Bump typo3/testing-framework ^8.2.0

Christian Kuhn CR +2 V +2 Easy +15 −15 updated 06/25/24, 23:14

Commit message

> composer req --dev typo3/testing-framework:^8.2.0

A minor release upgrade of TF needs minor
type hint adaptions to keep phpstan happy.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 612

  1. Christian Kuhn uploaded patch set 1 06/25/24, 22:20

  2. core-ci voted on patch set 1 V -1 06/25/24, 22:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60327

  3. Christian Kuhn uploaded patch set 2 V -1 06/25/24, 22:30

  4. core-ci voted on patch set 2 V +1 06/25/24, 22:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60328

  5. core-ci commented on patch set 2 06/25/24, 22:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60329

  6. Christian Kuhn uploaded patch set 3 V +1 06/25/24, 22:56

  7. Christian Kuhn updated the commit message in patch set 4 06/25/24, 22:58

  8. core-ci voted on patch set 4 V +1 06/25/24, 23:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60331

  9. core-ci voted on patch set 3 V +1 06/25/24, 23:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60330

  10. core-ci commented on patch set 4 06/25/24, 23:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60332

  11. Christian Kuhn commented on patch set 4 CR +2 V +2 06/25/24, 23:14

    I hope it's ok to merge here to keep CI nightly max green.
  12. Christian Kuhn merged patch set 5 06/25/24, 23:14