Review main Merged

84924[FEATURE] Add PSR-14 event to modify available countries

Georg Ringer CR +2 V +2 Normal +207 −12 updated 08/06/24, 13:18

Commit message

`\TYPO3\CMS\Core\Country\CountryProvider` is extended by a new PSR-14
event `\TYPO3\CMS\Core\Country\Event\BeforeCountriesEvaluatedEvent` to
change the countries available in the provider and all usages like the
CountrySelectViewHelper.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 4259

Show 2434 earlier messages
  1. Georg Ringer uploaded patch set 1 06/26/24, 03:53

  2. Georg Ringer commented on patch set 1 06/26/24, 03:53

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 06/26/24, 04:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60341

  4. Lina Wolf commented on patch set 1 06/26/24, 04:51

    Thanks for taking care of this, I will test it later this week
  5. Benni Mack updated the commit message in patch set 2 V -1 06/26/24, 05:19

  6. Benni Mack updated the commit message in patch set 3 06/26/24, 05:19

  7. Benni Mack uploaded patch set 4 06/26/24, 05:25

  8. core-ci voted on patch set 2 V -1 06/26/24, 05:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60353

  9. core-ci voted on patch set 3 V -1 06/26/24, 05:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60354

  10. core-ci voted on patch set 4 V -1 06/26/24, 05:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60355

  11. Fabien Udriot voted on patch set 4 CR +1 06/26/24, 06:42

  12. Georg Ringer uploaded patch set 5 CR +1 V -1 06/26/24, 07:12

  13. core-ci voted on patch set 5 V +1 06/26/24, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60356

  14. Oli Bartsch commented on patch set 5 06/26/24, 08:49

    Pleas let's add at least one test for the new Event, which checks whether the event is triggered and the countries in the provider are actually changed.
  15. Georg Ringer uploaded patch set 6 V +1 06/26/24, 11:13

  16. core-ci voted on patch set 6 V -1 06/26/24, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60374

  17. Georg Ringer rebased onto patch set 7 V -1 06/26/24, 12:23

  18. core-ci voted on patch set 7 V +1 06/26/24, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60383

  19. Simon Schaufelberger voted on patch set 7 CR +1 06/28/24, 18:33

  20. Christian Kuhn commented on patch set 7 CR -1 06/28/24, 18:40

    CountryProvider.php:29

    why shared: false? the result should be semi-static and built exactly once when needed?!
  21. Georg Ringer commented on patch set 8 CR +1 V +1 06/28/24, 20:01

    Published edit on patch set 7.
  22. core-ci voted on patch set 8 V +1 06/28/24, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60598

  23. Georg Ringer rebased onto patch set 9 V +1 07/27/24, 18:21

  24. core-ci voted on patch set 9 V +1 07/27/24, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62315

  25. Chris Müller commented on patch set 9 07/31/24, 16:20

    Feature-104168-PSR-14EventForModifyingCountries.rst:17

    "... to remove and countries ..." sounds strange. I assume it should be "... to remove and add countries ..."?

    Feature-104168-PSR-14EventForModifyingCountries.rst:40

    Giving the event is superfluous.

    Feature-104168-PSR-14EventForModifyingCountries.rst:64

    What about overriding the countries.xlf via locallangXMLOverride?
  26. Lina Wolf uploaded patch set 10 V +1 08/01/24, 05:59

  27. Lina Wolf commented on patch set 10 08/01/24, 06:00

    Feature-104168-PSR-14EventForModifyingCountries.rst:17 Reply

    Done

    Feature-104168-PSR-14EventForModifyingCountries.rst:40 Reply

    Done

    Feature-104168-PSR-14EventForModifyingCountries.rst:64 Reply

    Done
  28. Lina Wolf commented on patch set 10 08/01/24, 06:01

    CountryProvider.php:29 Reply

    Done
  29. Lina Wolf commented on patch set 10 08/01/24, 06:03

    Reply

    Done
  30. core-ci voted on patch set 10 V +1 08/01/24, 06:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62580

  31. Simon Schaufelberger wrote 08/01/24, 09:30

    Removed reviewer Simon Schaufelberger.
  32. Anja Leichsenring voted on patch set 10 CR +1 V +1 08/01/24, 11:46

  33. Georg Ringer uploaded patch set 11 CR +1 V +1 08/01/24, 12:13

  34. Anja Leichsenring voted on patch set 11 CR +1 V +1 08/01/24, 12:17

  1. core-ci voted on patch set 11 V +1 08/01/24, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62588

  2. Garvin Hicking commented on patch set 11 08/01/24, 12:44

    Feature-104168-PSR-14EventForModifyingCountries.rst:18

    "to add, remove and alter" - otherwise it sounds as if you could only remove.

    Feature-104168-PSR-14EventForModifyingCountries.rst:71

    Could we maybe also add an example of that DTO way? I could try to insert that, once I myself know how to do it ;)
  3. Lina Wolf uploaded patch set 12 CR +1 V +1 08/01/24, 14:03

  4. Lina Wolf commented on patch set 12 08/01/24, 14:04

    Feature-104168-PSR-14EventForModifyingCountries.rst:18 Reply

    Done

    Feature-104168-PSR-14EventForModifyingCountries.rst:71 Reply

    I think locallangXMLOverride is the better solution anyway, so I added an example of that.
  5. core-ci voted on patch set 12 V +1 08/01/24, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62591

  6. Garvin Hicking voted on patch set 12 CR +1 V +1 08/01/24, 14:30

  7. Christian Kuhn commented on patch set 12 CR -1 08/06/24, 11:31

    CountryProvider.php:29

    this obsoletes the entry is services.yaml.
  8. Christian Kuhn commented on patch set 12 08/06/24, 11:43

    CountryProvider.php:29 Reply

    and shared:true is obsolete, since that's default.
  9. Christian Kuhn commented on patch set 12 08/06/24, 11:43

    on it.
  10. Christian Kuhn uploaded patch set 13 CR +1 V +1 08/06/24, 11:48

  11. Christian Kuhn commented on patch set 12 CR -1 08/06/24, 11:48

  12. Christian Kuhn uploaded patch set 14 08/06/24, 11:53

  13. Christian Kuhn uploaded patch set 15 08/06/24, 11:54

  14. Benni Mack voted on patch set 15 CR +1 V +1 08/06/24, 11:56

  15. core-ci voted on patch set 13 V -1 08/06/24, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62912

  16. Christian Kuhn uploaded patch set 16 CR +1 V +1 08/06/24, 12:03

  17. core-ci voted on patch set 15 V -1 08/06/24, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62915

  18. core-ci voted on patch set 16 V -1 08/06/24, 12:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62917

  19. Christian Kuhn uploaded patch set 17 V -1 08/06/24, 12:49

  20. core-ci voted on patch set 17 V -1 08/06/24, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62932

  21. Christian Kuhn uploaded patch set 18 V -1 08/06/24, 13:06

  22. core-ci voted on patch set 18 V +1 08/06/24, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62936

  23. Christian Kuhn voted on patch set 18 CR +1 V +1 08/06/24, 13:15

  24. Benni Mack voted on patch set 18 CR +2 V +2 08/06/24, 13:18

  25. Benni Mack merged patch set 19 08/06/24, 13:18