84924[FEATURE] Add PSR-14 event to modify available countries
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Country/Event/BeforeCountriesEvaluatedEvent.phpnew+44 −0
- typo3/sysext/core/Classes/Country/CountryProvider.php5+11 −1
- typo3/sysext/core/Configuration/Services.yaml+0 −4
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-104168-PSR-14EventForModifyingCountries.rst4new+95 −0
- typo3/sysext/core/Tests/Functional/Country/CountryProviderTest.phpnew+51 −0
- typo3/sysext/core/Tests/Unit/Country/CountryProviderTest.php+5 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CountrySelectViewHelper.php+1 −3
Review log 4259
Show 2434 earlier messages
-
Georg Ringer uploaded patch set 1 06/26/24, 03:53
-
Georg Ringer commented on patch set 1 06/26/24, 03:53
This change is ready for review. -
core-ci voted on patch set 1 V -1 06/26/24, 04:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60341
-
Lina Wolf commented on patch set 1 06/26/24, 04:51
Thanks for taking care of this, I will test it later this week -
Benni Mack updated the commit message in patch set 2
V -106/26/24, 05:19 -
Benni Mack updated the commit message in patch set 3 06/26/24, 05:19
-
Benni Mack uploaded patch set 4 06/26/24, 05:25
-
core-ci voted on patch set 2 V -1 06/26/24, 05:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60353
-
core-ci voted on patch set 3 V -1 06/26/24, 05:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60354
-
core-ci voted on patch set 4 V -1 06/26/24, 05:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60355
-
Fabien Udriot voted on patch set 4 CR +1 06/26/24, 06:42
-
Georg Ringer uploaded patch set 5
CR +1V -106/26/24, 07:12 -
core-ci voted on patch set 5 V +1 06/26/24, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60356
-
Oli Bartsch commented on patch set 5 06/26/24, 08:49
Pleas let's add at least one test for the new Event, which checks whether the event is triggered and the countries in the provider are actually changed. -
Georg Ringer uploaded patch set 6
V +106/26/24, 11:13 -
core-ci voted on patch set 6 V -1 06/26/24, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60374
-
Georg Ringer rebased onto patch set 7
V -106/26/24, 12:23 -
core-ci voted on patch set 7 V +1 06/26/24, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60383
-
Simon Schaufelberger voted on patch set 7 CR +1 06/28/24, 18:33
-
Christian Kuhn commented on patch set 7 CR -1 06/28/24, 18:40
CountryProvider.php:29why shared: false? the result should be semi-static and built exactly once when needed?! -
Georg Ringer commented on patch set 8
CR +1V +106/28/24, 20:01Published edit on patch set 7. -
core-ci voted on patch set 8 V +1 06/28/24, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60598
-
Georg Ringer rebased onto patch set 9
V +107/27/24, 18:21 -
core-ci voted on patch set 9 V +1 07/27/24, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62315
-
Chris Müller commented on patch set 9 07/31/24, 16:20
Feature-104168-PSR-14EventForModifyingCountries.rst:17"... to remove and countries ..." sounds strange. I assume it should be "... to remove and add countries ..."?Feature-104168-PSR-14EventForModifyingCountries.rst:40Giving the event is superfluous.Feature-104168-PSR-14EventForModifyingCountries.rst:64What about overriding the countries.xlf via locallangXMLOverride? -
Lina Wolf uploaded patch set 10
V +108/01/24, 05:59 -
Lina Wolf commented on patch set 10 08/01/24, 06:00
Feature-104168-PSR-14EventForModifyingCountries.rst:17ReplyDoneFeature-104168-PSR-14EventForModifyingCountries.rst:40ReplyDoneFeature-104168-PSR-14EventForModifyingCountries.rst:64ReplyDone -
Lina Wolf commented on patch set 10 08/01/24, 06:01
CountryProvider.php:29ReplyDone -
Lina Wolf commented on patch set 10 08/01/24, 06:03
Reply
Done -
core-ci voted on patch set 10 V +1 08/01/24, 06:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62580
-
Simon Schaufelberger wrote 08/01/24, 09:30
Removed reviewer Simon Schaufelberger. -
Anja Leichsenring voted on patch set 10 CR +1 V +1 08/01/24, 11:46
-
Georg Ringer uploaded patch set 11
CR +1V +108/01/24, 12:13 -
Anja Leichsenring voted on patch set 11 CR +1 V +1 08/01/24, 12:17
-
core-ci voted on patch set 11 V +1 08/01/24, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62588
-
Garvin Hicking commented on patch set 11 08/01/24, 12:44
Feature-104168-PSR-14EventForModifyingCountries.rst:18"to add, remove and alter" - otherwise it sounds as if you could only remove.Feature-104168-PSR-14EventForModifyingCountries.rst:71Could we maybe also add an example of that DTO way? I could try to insert that, once I myself know how to do it ;) -
Lina Wolf uploaded patch set 12
CR +1V +108/01/24, 14:03 -
Lina Wolf commented on patch set 12 08/01/24, 14:04
Feature-104168-PSR-14EventForModifyingCountries.rst:18ReplyDoneFeature-104168-PSR-14EventForModifyingCountries.rst:71ReplyI think locallangXMLOverride is the better solution anyway, so I added an example of that. -
core-ci voted on patch set 12 V +1 08/01/24, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62591
-
Garvin Hicking voted on patch set 12 CR +1 V +1 08/01/24, 14:30
-
Christian Kuhn commented on patch set 12 CR -1 08/06/24, 11:31
CountryProvider.php:29this obsoletes the entry is services.yaml. -
Christian Kuhn commented on patch set 12 08/06/24, 11:43
CountryProvider.php:29Replyand shared:true is obsolete, since that's default. -
Christian Kuhn commented on patch set 12 08/06/24, 11:43
on it. -
Christian Kuhn uploaded patch set 13
CR +1V +108/06/24, 11:48 -
Christian Kuhn commented on patch set 12 CR -1 08/06/24, 11:48
CountryProvider.php:29Reply -
Christian Kuhn uploaded patch set 14 08/06/24, 11:53
-
Christian Kuhn uploaded patch set 15 08/06/24, 11:54
-
Benni Mack voted on patch set 15 CR +1 V +1 08/06/24, 11:56
-
core-ci voted on patch set 13 V -1 08/06/24, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62912
-
Christian Kuhn uploaded patch set 16
CR +1V +108/06/24, 12:03 -
core-ci voted on patch set 15 V -1 08/06/24, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62915
-
core-ci voted on patch set 16 V -1 08/06/24, 12:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62917
-
Christian Kuhn uploaded patch set 17
V -108/06/24, 12:49 -
core-ci voted on patch set 17 V -1 08/06/24, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62932
-
Christian Kuhn uploaded patch set 18
V -108/06/24, 13:06 -
core-ci voted on patch set 18 V +1 08/06/24, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62936
-
Christian Kuhn voted on patch set 18 CR +1 V +1 08/06/24, 13:15
-
Benni Mack voted on patch set 18 CR +2 V +2 08/06/24, 13:18
-
Benni Mack merged patch set 19 08/06/24, 13:18