Review main Merged

84929[TASK] Add custom icon example inside the `styleguide` infobox examples

Philipp Kuhlmay CR +2 V +2 Easy +19 −3 updated 06/28/24, 12:31

Commit message

This adds an example on how to use a custom icon inside the Infobox Fluid-Viewhelper.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 913

  1. Philipp Kuhlmay uploaded patch set 1 06/26/24, 15:07

  2. core-ci voted on patch set 1 V +1 06/26/24, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60397

  3. Philipp Kuhlmay updated the commit message in patch set 2 V +1 06/28/24, 06:20

  4. Philipp Kuhlmay updated the commit message in patch set 3 06/28/24, 06:25

  5. core-ci voted on patch set 2 V +1 06/28/24, 06:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60537

  6. core-ci voted on patch set 3 V +1 06/28/24, 06:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60538

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 06/28/24, 06:43

  8. Oli Bartsch commented on patch set 3 CR -1 06/28/24, 07:53

    Infobox.html:30

    in

    Infobox.html:36

    This does not match the example
  9. Oli Bartsch uploaded patch set 4 CR +1 V +1 06/28/24, 07:58

  10. Oli Bartsch commented on patch set 4 CR +1 V +1 06/28/24, 07:58

    Infobox.html:30 Reply

    Done

    Infobox.html:36 Reply

    Done
  11. core-ci voted on patch set 4 V +1 06/28/24, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60539

  12. Stefan Bürk voted on patch set 4 CR +2 V +2 06/28/24, 12:31

  13. Stefan Bürk merged patch set 5 06/28/24, 12:31