84932[BUGFIX] Add specific file link generator for ext:styleguide
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Sebastian Iffland +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2535
Show 610 earlier messages
-
Philipp Kuhlmay uploaded patch set 1 06/26/24, 16:16
-
core-ci voted on patch set 1 V +1 06/26/24, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60402
-
Philipp Kuhlmay commented on patch set 1 06/28/24, 06:28
-
Anja Leichsenring uploaded patch set 2
V +110/16/24, 09:53 -
Anja Leichsenring commented on patch set 2 10/16/24, 09:54
KauderwelschService.php:125ReplyDone -
Anja Leichsenring updated the commit message in patch set 3 10/16/24, 09:55
-
core-ci voted on patch set 2 V +1 10/16/24, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67873
-
Anja Leichsenring updated the commit message in patch set 4 10/16/24, 10:07
-
core-ci voted on patch set 3 V +1 10/16/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67874
-
core-ci voted on patch set 4 V +1 10/16/24, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67877
-
Garvin Hicking commented on patch set 4 10/16/24, 10:58
tx_styleguide_elements_basic.php:527Maybe add "png,jpg" here? Otherwise people with existing EXT:styleguide records might not be able to save their records anymore with PNGs attached? -
Anja Leichsenring commented on patch set 5
V +110/16/24, 12:22Published edit on patch set 4. -
Anja Leichsenring commented on patch set 5 10/16/24, 12:22
tx_styleguide_elements_basic.php:527ReplyAcknowledged -
core-ci voted on patch set 5 V +1 10/16/24, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67881
-
Garvin Hicking commented on patch set 6
V +110/16/24, 12:59Published edit on patch set 5. -
Garvin Hicking updated the commit message in patch set 7 10/16/24, 12:59
-
core-ci voted on patch set 6 V +1 10/16/24, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67882
-
core-ci voted on patch set 7 V +1 10/16/24, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67883
-
Thomas Hohn voted on patch set 7 CR +1 10/21/24, 07:12
-
Sebastian Iffland commented on patch set 7 CR -1 10/21/24, 15:19
tx_styleguide_elements_basic.php:527Should be array form `['jpg','png']` according to https://docs.typo3.org/m/typo3/reference-tca/main/en-us/ColumnsConfig/Type/Link/Index.html#confval-link-appearance, if read right. -
Benni Mack commented on patch set 7 11/20/24, 17:34
Philipp, care to update? -
Philipp Kuhlmay rebased onto patch set 8
CR +1V +111/22/24, 11:03 -
core-ci voted on patch set 8 V +1 11/22/24, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70030
-
Philipp Kuhlmay commented on patch set 8 11/22/24, 11:34
tx_styleguide_elements_basic.php:527ReplyHi both spellings work. ['jpg','png'] and ['jpg,png']. In the linked documentation there is nothing about allowedFileExtensions, only allowedExtensions (without the word 'File'). But I found this one: https://docs.typo3.org/m/typo3/reference-tca/main/en-us/singlehtml/#override-the-foreign-selector-field-target There the spelling is 'jpg,svg', so I leave this as it is. If I am incorrect, I can change it, no problem. -
Philipp Kuhlmay uploaded patch set 9 11/22/24, 11:34
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
Philipp Kuhlmay commented on patch set 9 11/22/24, 11:37
Reply
Hi Benni, I rebased this to the main branch and tested it again. The latest changes work for me. There is only one thing unresolved: the spelling of the allowedFileExtensions. Both spellings did work for me, so I did not change this at the moment. -
core-ci voted on patch set 9 V +1 11/22/24, 11:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70035
-
Sebastian Iffland commented on patch set 9 CR +1 11/22/24, 12:18
tx_styleguide_elements_basic.php:527ReplyYou're right, `allowedFileExtensions` is neither in documentation, even-though this one applies according to https://github.com/TYPO3/typo3/blob/0b7f4f58bf6387e2a1d54a03a4132f4825394576/typo3/sysext/backend/Classes/Form/Element/LinkElement.php#L480-L484. Possible lack in the docs. Checking https://github.com/TYPO3/typo3/blob/0b7f4f58bf6387e2a1d54a03a4132f4825394576/typo3/sysext/backend/Classes/Form/FieldControl/LinkPopup.php#L68-L73 tells the truth, that as already mentioned both versions are covered, but finally a string list is generated anyways. -
Oli Bartsch uploaded patch set 10
CR +1V +112/12/24, 08:12 -
core-ci voted on patch set 10 V +1 12/12/24, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71008
-
Oli Bartsch commented on patch set 10 CR +1 V +1 12/12/24, 08:31
Reply
Done -
Garvin Hicking voted on patch set 10 CR +1 V +1 12/12/24, 08:45
-
Sebastian Iffland voted on patch set 10 CR +1 12/12/24, 08:54
-
Oli Bartsch voted on patch set 10 CR +2 V +2 12/12/24, 08:56
-
Oli Bartsch merged patch set 11 12/12/24, 08:56
KauderwelschService.php:125