Review main Merged

84932[BUGFIX] Add specific file link generator for ext:styleguide

Philipp Kuhlmay CR +2 V +2 Normal +56 −2 updated 12/12/24, 08:56

Commit message

TCA-Examples inside EXT:styleguide provide generated example data
to demonstrate functionality. Up until now, no specified generator
option could be applied to fields defined as
`type=link` and `allowedFileExtensions` applied,
meaning the link for a file should be created.
This was a simple web page link until now, which
did not reflect the wanted behaviour.

A new generator is now introduced, providing links to the example
files ext:styleguide ships.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Sebastian Iffland +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2535

Show 610 earlier messages
  1. Philipp Kuhlmay uploaded patch set 1 06/26/24, 16:16

  2. core-ci voted on patch set 1 V +1 06/26/24, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60402

  3. Philipp Kuhlmay commented on patch set 1 06/28/24, 06:28

    KauderwelschService.php:125

    This is not the final solution yet. The uid should be dynamically. I have no clue how to solve this for the moment.
  4. Anja Leichsenring uploaded patch set 2 V +1 10/16/24, 09:53

  5. Anja Leichsenring commented on patch set 2 10/16/24, 09:54

    KauderwelschService.php:125 Reply

    Done
  6. Anja Leichsenring updated the commit message in patch set 3 10/16/24, 09:55

  7. core-ci voted on patch set 2 V +1 10/16/24, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67873

  8. Anja Leichsenring updated the commit message in patch set 4 10/16/24, 10:07

  9. core-ci voted on patch set 3 V +1 10/16/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67874

  10. core-ci voted on patch set 4 V +1 10/16/24, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67877

  1. Garvin Hicking commented on patch set 4 10/16/24, 10:58

    tx_styleguide_elements_basic.php:527

    Maybe add "png,jpg" here? Otherwise people with existing EXT:styleguide records might not be able to save their records anymore with PNGs attached?
  2. Anja Leichsenring commented on patch set 5 V +1 10/16/24, 12:22

    Published edit on patch set 4.
  3. Anja Leichsenring commented on patch set 5 10/16/24, 12:22

    tx_styleguide_elements_basic.php:527 Reply

    Acknowledged
  4. core-ci voted on patch set 5 V +1 10/16/24, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67881

  5. Garvin Hicking commented on patch set 6 V +1 10/16/24, 12:59

    Published edit on patch set 5.
  6. Garvin Hicking updated the commit message in patch set 7 10/16/24, 12:59

  7. core-ci voted on patch set 6 V +1 10/16/24, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67882

  8. core-ci voted on patch set 7 V +1 10/16/24, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67883

  9. Thomas Hohn voted on patch set 7 CR +1 10/21/24, 07:12

  10. Sebastian Iffland commented on patch set 7 CR -1 10/21/24, 15:19

    tx_styleguide_elements_basic.php:527

  11. Benni Mack commented on patch set 7 11/20/24, 17:34

    Philipp, care to update?
  12. Philipp Kuhlmay rebased onto patch set 8 CR +1 V +1 11/22/24, 11:03

  13. core-ci voted on patch set 8 V +1 11/22/24, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70030

  14. Philipp Kuhlmay commented on patch set 8 11/22/24, 11:34

    tx_styleguide_elements_basic.php:527 Reply

    Hi both spellings work. ['jpg','png'] and ['jpg,png']. In the linked documentation there is nothing about allowedFileExtensions, only allowedExtensions (without the word 'File'). But I found this one: https://docs.typo3.org/m/typo3/reference-tca/main/en-us/singlehtml/#override-the-foreign-selector-field-target There the spelling is 'jpg,svg', so I leave this as it is. If I am incorrect, I can change it, no problem.
  15. Philipp Kuhlmay uploaded patch set 9 11/22/24, 11:34

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  16. Philipp Kuhlmay commented on patch set 9 11/22/24, 11:37

    Reply

    Hi Benni, I rebased this to the main branch and tested it again. The latest changes work for me. There is only one thing unresolved: the spelling of the allowedFileExtensions. Both spellings did work for me, so I did not change this at the moment.
  17. core-ci voted on patch set 9 V +1 11/22/24, 11:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70035

  18. Sebastian Iffland commented on patch set 9 CR +1 11/22/24, 12:18

    tx_styleguide_elements_basic.php:527 Reply

    You're right, `allowedFileExtensions` is neither in documentation, even-though this one applies according to https://github.com/TYPO3/typo3/blob/0b7f4f58bf6387e2a1d54a03a4132f4825394576/typo3/sysext/backend/Classes/Form/Element/LinkElement.php#L480-L484. Possible lack in the docs. Checking https://github.com/TYPO3/typo3/blob/0b7f4f58bf6387e2a1d54a03a4132f4825394576/typo3/sysext/backend/Classes/Form/FieldControl/LinkPopup.php#L68-L73 tells the truth, that as already mentioned both versions are covered, but finally a string list is generated anyways.
  19. Oli Bartsch uploaded patch set 10 CR +1 V +1 12/12/24, 08:12

  20. core-ci voted on patch set 10 V +1 12/12/24, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71008

  21. Oli Bartsch commented on patch set 10 CR +1 V +1 12/12/24, 08:31

    Reply

    Done
  22. Garvin Hicking voted on patch set 10 CR +1 V +1 12/12/24, 08:45

  23. Sebastian Iffland voted on patch set 10 CR +1 12/12/24, 08:54

  24. Oli Bartsch voted on patch set 10 CR +2 V +2 12/12/24, 08:56

  25. Oli Bartsch merged patch set 11 12/12/24, 08:56