Review main Merged

84933[BUGFIX] Make BackendGroupsExplicitAllowDeny wizard indicate errors

Garvin Hicking CR +2 V +2 Easy +3 −1 updated 06/27/24, 21:09

Commit message

The migration wizard BackendGroupsExplicitAllowDeny
('Migrate backend groups "explicit_allowdeny" field to
simplified format') returns Symfony formatted error messages
for specific single rows.

Before this patch, it was still reported as a successful
migration, and the success message is formatted with
"everything is great" green background, so that errors
may not receive attention.

This patch changes the wizard to return a failure state.
This will then return the messages formatted as errors.

Since the wizard migrates all rows (even the faulty ones),
the wizard can then be re-executed to be marked as "done".

This is not ideal, but because of the way Symfony
output streams cannot reveal if they contain an error
when the stream is retrieved, there is little other choice.

Otherwise the Wizard API would need to receive a breaking
API change to allow to carry additional meta information
about "warnings" rather than just errors, which is
beyond scope for current development state.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Garvin Hicking uploaded patch set 1 06/26/24, 16:25

  2. core-ci voted on patch set 1 V +1 06/26/24, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60403

  3. Garvin Hicking updated the commit message in patch set 2 V +1 06/26/24, 16:31

    relate ticket
  4. Garvin Hicking commented on patch set 2 06/26/24, 16:31

    (Note that for v13 main, migration wizard error and success notices currently are broken and not displayed. This patch works in v12, and should work in v13 once that bug is fixed; see bug https://forge.typo3.org/issues/104225)
  5. core-ci voted on patch set 2 V +1 06/26/24, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60404

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 06/27/24, 20:33

  7. Christian Kuhn commented on patch set 2 CR +1 V +1 06/27/24, 20:57

    Reply

    Acknowledged
  8. Stefan Bürk voted on patch set 2 CR +2 V +2 06/27/24, 20:59

  9. Stefan Bürk merged patch set 3 06/27/24, 21:09