Review main Merged

84934[BUGFIX] Allow empty field to override default in DataHandler

Georg Ringer CR +2 V +2 Easy +16 −1 updated 02/18/25, 14:45

Commit message

Given a TCA type "select" with various options. One option using the
value of "". If a TCA config key "default" is set, which is different
from an empty string, it has been not possible to select the option
with an empty string as value.

As a solution, it is checked if the value handed to DataHandler is part
of the available option items and their values before using the default
config value as fallback.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1823

  1. Georg Ringer uploaded patch set 1 06/26/24, 17:42

  2. Georg Ringer commented on patch set 1 06/26/24, 17:42

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 06/26/24, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60406

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 06/26/24, 18:51

    What a find. Odd case to define it like this, but the strict check should hopefully not have side-effects I'm aware of
  5. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 06/26/24, 19:16

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 06/26/24, 19:16

  7. core-ci voted on patch set 2 V +1 06/26/24, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60411

  8. Garvin Hicking updated the commit message in patch set 3 CR +1 V +1 06/27/24, 10:51

  9. Garvin Hicking voted on patch set 3 CR +1 V +1 06/27/24, 10:51

  10. core-ci voted on patch set 3 V +1 06/27/24, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60449

  11. David Menzel voted on patch set 3 CR +1 06/27/24, 13:24

  12. Georg Ringer commented on patch set 3 CR -2 06/27/24, 13:27

    blocked to test if default is still set if e.g. permissions are set for that field
  13. Georg Ringer commented on patch set 3 CR 0 06/27/24, 13:57

    @lolli: if a user doesn't have any permissions for a field, the default is completely ignored
  14. Markus Klein updated the commit message in patch set 4 CR +1 V +1 07/23/24, 14:11

  15. Markus Klein voted on patch set 4 CR +1 07/23/24, 14:12

  16. core-ci voted on patch set 4 V +1 07/23/24, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62016

  17. Benni Mack updated the commit message in patch set 5 CR +1 V +1 10/18/24, 13:39

  18. Benni Mack rebased onto patch set 6 02/17/25, 19:42

  19. core-ci voted on patch set 6 V +1 02/17/25, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74265

  20. Garvin Hicking voted on patch set 6 CR +1 V +1 02/17/25, 21:02

  21. Benni Mack voted on patch set 6 CR +1 V +1 02/18/25, 14:43

  22. Georg Ringer voted on patch set 6 CR +2 V +2 02/18/25, 14:45

  23. Georg Ringer merged patch set 7 02/18/25, 14:45