Review main Merged

84936[TASK] Clean up extbase TypeConverters

Torben Hansen CR +2 V +2 Hard +222 −96 updated 06/27/24, 20:13

Commit message

This change cleans up and streamlines Extbase type converters by:

* using typed properties
* adding proper return types for the `convertFrom` method
* marking all `convertFrom` methods `@internal`
* make `$configuration` attribute in `convertFrom` method explicitly
  nullable
* removing unnecessary qualifiers
* removing superfluous comparisons

Additionally, more tests have been added for the `ArrayConverter`
and `FloatConverter`.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 811

  1. Torben Hansen uploaded patch set 1 06/26/24, 18:11

  2. core-ci voted on patch set 1 V -1 06/26/24, 18:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60409

  3. Torben Hansen rebased onto patch set 2 V -1 06/27/24, 05:39

  4. core-ci voted on patch set 2 V +1 06/27/24, 05:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60435

  5. Benni Mack commented on patch set 2 06/27/24, 06:05

    AbstractFileFolderConverter.php:54

    not needed, as the class is already "internal"
  6. Torben Hansen uploaded patch set 3 V +1 06/27/24, 11:07

  7. core-ci voted on patch set 3 V +1 06/27/24, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60451

  8. Torben Hansen commented on patch set 2 06/27/24, 11:22

    AbstractFileFolderConverter.php:54 Reply

    Done
  9. Benni Mack voted on patch set 3 CR +1 V +1 06/27/24, 17:29

  10. Stefan Bürk voted on patch set 3 CR +2 V +2 06/27/24, 20:13

  11. Stefan Bürk merged patch set 4 06/27/24, 20:13