84936[TASK] Clean up extbase TypeConverters
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 18
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/extbase/Classes/Property/TypeConverter/AbstractFileFolderConverter.php2+3 −7
- typo3/sysext/extbase/Classes/Property/TypeConverter/ArrayConverter.php+8 −6
- typo3/sysext/extbase/Classes/Property/TypeConverter/BooleanConverter.php+7 −2
- typo3/sysext/extbase/Classes/Property/TypeConverter/CoreTypeConverter.php+6 −4
- typo3/sysext/extbase/Classes/Property/TypeConverter/DateTimeConverter.php+11 −10
- typo3/sysext/extbase/Classes/Property/TypeConverter/EnumConverter.php+6 −3
- typo3/sysext/extbase/Classes/Property/TypeConverter/FileConverter.php+4 −2
- typo3/sysext/extbase/Classes/Property/TypeConverter/FileReferenceConverter.php+2 −2
- typo3/sysext/extbase/Classes/Property/TypeConverter/FloatConverter.php+7 −3
- typo3/sysext/extbase/Classes/Property/TypeConverter/FolderConverter.php+2 −2
- typo3/sysext/extbase/Classes/Property/TypeConverter/IntegerConverter.php+7 −4
- typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectConverter.php+24 −16
- typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectStorageConverter.php+12 −4
- typo3/sysext/extbase/Classes/Property/TypeConverter/PersistentObjectConverter.php+29 −22
- typo3/sysext/extbase/Classes/Property/TypeConverter/StringConverter.php+7 −2
- typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/ArrayConverterTest.php+63 −2
- typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/FloatConverterTest.php+24 −0
Review log 811
-
Torben Hansen uploaded patch set 1 06/26/24, 18:11
-
core-ci voted on patch set 1 V -1 06/26/24, 18:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60409
-
Torben Hansen rebased onto patch set 2
V -106/27/24, 05:39 -
core-ci voted on patch set 2 V +1 06/27/24, 05:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60435
-
Benni Mack commented on patch set 2 06/27/24, 06:05
-
Torben Hansen uploaded patch set 3
V +106/27/24, 11:07 -
core-ci voted on patch set 3 V +1 06/27/24, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60451
-
Torben Hansen commented on patch set 2 06/27/24, 11:22
AbstractFileFolderConverter.php:54ReplyDone -
Benni Mack voted on patch set 3 CR +1 V +1 06/27/24, 17:29
-
Stefan Bürk voted on patch set 3 CR +2 V +2 06/27/24, 20:13
-
Stefan Bürk merged patch set 4 06/27/24, 20:13
AbstractFileFolderConverter.php:54