Review main Merged

84938[TASK] Fix typo in class name

Georg Ringer CR +2 V +2 Easy +3 −3 updated 06/27/24, 20:49

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Riccardo De Contardi +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Riccardo De Contardi +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Georg Ringer uploaded patch set 1 06/26/24, 19:50

  2. core-ci voted on patch set 1 V -1 06/26/24, 19:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60412

  3. Riccardo De Contardi commented on patch set 1 CR +1 V +1 06/26/24, 20:12

    This change is ready for review.
    Tested on latest main. I've found out that the class "pagination-label" was already used also on typo3/sysext/backend/Resources/Private/Templates/ListNavigation.html but it looks like it is superfluous (if I am not wrong)
  4. Georg Ringer uploaded patch set 2 CR +1 V +1 06/26/24, 20:25

  5. Riccardo De Contardi commented on patch set 2 CR +1 V +1 06/26/24, 20:30

    tested on latest main. See my prev. comment
  6. core-ci voted on patch set 2 V +1 06/26/24, 20:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60413

  7. Benni Mack voted on patch set 2 CR +1 V +1 06/26/24, 20:49

  8. Stefan Bürk voted on patch set 2 CR +1 V +1 06/27/24, 04:58

  9. Oliver Klee voted on patch set 2 CR +1 06/27/24, 07:37

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 06/27/24, 20:49

  11. Christian Kuhn merged patch set 3 06/27/24, 20:49