84939[BUGFIX] Support old `setup.txt` filenames in @import
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeFromLineStreamBuilder.php+40 −26
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/AbsoluteImport/Scenario5/setup.txtnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/TreeFromLineStreamBuilderTest.php+15 −0
Review log 710
-
Thorben Nissen uploaded patch set 1 06/27/24, 07:47
-
core-ci voted on patch set 1 V -1 06/27/24, 07:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60439
-
Thorben Nissen uploaded patch set 2 06/27/24, 07:54
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
Thorben Nissen uploaded patch set 3
V -106/27/24, 07:55 -
core-ci voted on patch set 2 V -1 06/27/24, 07:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60440
-
core-ci voted on patch set 3 V +1 06/27/24, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60441
-
Christian Kuhn commented on patch set 3 CR -1 06/27/24, 13:52
Hey. I don't think we should do this: TypoScript files should end with .typoscript, TsConfig files should end with .tsconfig. That's the convention. Endings .ts and .txt have various drawbacks, which is why we actively want to get rid of them: There are security concerns as well and the overlap with TypeScript. A first move towards .typoscript has been done with v9 @import implementation already, as documented with https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/9.0/Feature-82812-NewSyntaxForImportingTypoScriptFiles.html. When INCLUDE_TYPOSCRIPT will be deprecated (hopefully in v13), .txt and .ts are gone, leaving *maybe* only some last fallbacks layers somewhere. As such, it is *not* a bug to not consider .ts and .txt in @import and frieds, but strategy. The v12 docs state: Single files must end with .typoscript if included in frontend Typoscript. In backend TSconfig, single files should end with .tsconfig, but may end with .typoscript as well (for now). I need to ask you to adapt your instances accordingly: You could switch to @import along the way, to avoid another change when upgrading to v13 / v14. -
Georg Ringer commented on patch set 3 CR -1 06/27/24, 13:59
just what christian says. we should really move forward, even if this means updating some legacy stuff -
Christian Kuhn commented on patch set 3 06/27/24, 14:30
Hey. Thanks for the patch. As outlined above, it seems it will not find consensus, though. I hope its ok to abandon here. -
Christian Kuhn abandoned the change 06/27/24, 14:30