Review main Merged

84940[BUGFIX] Fix table column type for imageManipulation

Oli Bartsch CR +2 V +2 Easy +2 −1 updated 06/28/24, 04:51

Commit message

Also adds the type to the corresponding test.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Torben Hansen +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Torben Hansen +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 910

  1. Oli Bartsch uploaded patch set 1 06/27/24, 11:28

  2. core-ci voted on patch set 1 V +1 06/27/24, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60453

  3. Garvin Hicking commented on patch set 1 06/27/24, 14:30

    How can I verify/test this, what bug is caused by this?
  4. Oli Bartsch commented on patch set 1 06/27/24, 14:34

    Reply

    This currently had no consequences since the constant was not used anywhere. However it's still a bug since the type had a typo.
  5. Garvin Hicking commented on patch set 1 CR +1 V +1 06/27/24, 14:59

    Reply

    Thanks. I didn't really know where to look what this would affect and what I was missing :)
  6. Torben Hansen voted on patch set 1 CR +1 V +1 06/27/24, 16:17

  7. Benni Mack voted on patch set 1 CR +1 V +1 06/27/24, 16:28

  8. Oliver Hader voted on patch set 1 CR +1 06/27/24, 17:04

  9. Georg Ringer voted on patch set 1 CR +2 V +2 06/28/24, 04:51

  10. Georg Ringer merged patch set 2 06/28/24, 04:51