Review main Abandoned

84941[TASK] Use TableColumnType in NodeFactory

Oli Bartsch CR 0 V 0 Easy +25 −25 updated 06/28/24, 12:10

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1418

  1. Oli Bartsch uploaded patch set 1 06/27/24, 12:05

  2. core-ci voted on patch set 1 V -1 06/27/24, 12:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60454

  3. Oli Bartsch uploaded patch set 2 V -1 06/27/24, 12:34

  4. core-ci voted on patch set 2 V -1 06/27/24, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60456

  5. Oli Bartsch uploaded patch set 3 V -1 06/27/24, 12:59

  6. core-ci voted on patch set 3 V +1 06/27/24, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60459

  7. Georg Ringer voted on patch set 3 CR +1 V +1 06/27/24, 14:17

  8. Benni Mack commented on patch set 3 CR -1 06/27/24, 14:34

    TableColumnType.php:34

    that's not a TableColumnType?
  9. Oli Bartsch commented on patch set 3 06/27/24, 14:54

    TableColumnType.php:34 Reply

    IMO it is. It's used for column "languages" of (virtual) table "site".
  10. Benni Mack commented on patch set 3 06/27/24, 15:43

    TableColumnType.php:34 Reply

    Sure, but TableColumnType is for "TCA" (= Table Configuration Array) - and actually "siteLanguage" is only part of the FormEngine "Fake TCA". If done right, we'd need a clear list of types that can be used in TCA, some that can be used in "Site Configuration Rendering for FormEngine" and for Flex rendering. e.g. Extbase is using TableColumnType and thus could now allow "siteLanguage" as type? Shouldn't we cover this as well? What are you trying to achieve with this change?
  11. Christian Kuhn commented on patch set 3 CR -1 06/27/24, 15:48

    TableColumnType.php:34 Reply

    agreed: siteLanguage is not a general TCA type, it is a tribute to 'fake tca' thing from 'site' only. we shouldn't pollute tableColumnType with this - it is not a general available tca type, and it shouldn't claim it is.
  12. Oli Bartsch uploaded patch set 4 CR +1 V +1 06/27/24, 20:15

  13. Oli Bartsch commented on patch set 4 06/27/24, 20:15

    TableColumnType.php:34 Reply

    Done
  14. core-ci voted on patch set 4 V +1 06/27/24, 20:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60490

  15. Christian Kuhn voted on patch set 4 CR +1 V +1 06/28/24, 10:45

  16. Stefan Bürk voted on patch set 4 CR +1 V +1 06/28/24, 11:16

  17. Benni Mack commented on patch set 4 06/28/24, 11:20

    tbh, I don't see a benefit in this change other than mixing different things (TCA types with predefined FormEngine types) and complexity from reading with my eye (keys as a BackedEnum with ->value). I will abstain from voting
  18. Oli Bartsch abandoned the change 06/28/24, 12:10

    Not much benefit.