Review main Merged

84942[TASK] Streamline `SchemaMigratorTest` of `EXT:core`

Stefan Bürk CR +2 V +2 Hard +342 −160 updated 06/28/24, 21:00

Commit message

The SchemaMigratorTest currently works on a fully
populated database, which makes the tests more
brittle than they should be.

The patch uses a preparation in testing-framework
to let TF create a database, but not populate it
with tables, which stabilizes the tests.

> composer u typo3/testing-framework

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1427

Show 12 earlier messages
  1. Stefan Bürk uploaded patch set 1 06/27/24, 12:54

  2. core-ci voted on patch set 1 V -1 06/27/24, 13:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60458

  1. Stefan Bürk uploaded patch set 2 V -1 06/27/24, 14:49

  2. Stefan Bürk uploaded patch set 3 06/27/24, 14:51

  3. core-ci voted on patch set 2 V -1 06/27/24, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60469

  4. core-ci voted on patch set 3 V +1 06/27/24, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60471

  5. Stefan Bürk uploaded patch set 4 V +1 06/27/24, 15:20

  6. core-ci voted on patch set 4 V +1 06/27/24, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60473

  7. Stefan Bürk uploaded patch set 5 V +1 06/27/24, 16:27

  8. core-ci voted on patch set 5 V -1 06/27/24, 16:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60479

  9. core-ci voted on patch set 5 V +1 06/27/24, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60479

  10. Stefan Bürk uploaded patch set 6 V +1 06/28/24, 13:56

  11. core-ci voted on patch set 6 V +1 06/28/24, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60566

  12. core-ci voted on patch set 6 V -1 06/28/24, 14:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60568

  13. Stefan Bürk rebased onto patch set 7 V -1 06/28/24, 14:20

  14. core-ci voted on patch set 7 V +1 06/28/24, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60570

  15. core-ci voted on patch set 7 V -1 06/28/24, 14:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60571

  16. Christian Kuhn uploaded patch set 8 V -1 06/28/24, 18:12

  17. Christian Kuhn commented on patch set 8 CR -1 06/28/24, 18:14

    will run through nightly when the symfony issue is fixed.
  18. core-ci voted on patch set 8 V +1 06/28/24, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60589

  19. Christian Kuhn rebased onto patch set 9 CR -1 V +1 06/28/24, 18:56

  20. core-ci voted on patch set 9 V +1 06/28/24, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60595

  21. core-ci commented on patch set 9 06/28/24, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60596

  22. Christian Kuhn voted on patch set 9 CR +1 V +1 06/28/24, 19:25

  23. Garvin Hicking voted on patch set 9 CR +1 V +1 06/28/24, 21:00

  24. Stefan Bürk voted on patch set 9 CR +2 V +2 06/28/24, 21:00

  25. Stefan Bürk merged patch set 10 06/28/24, 21:00