Review main Merged

84943[BUGFIX] Respect "doSaveFieldName" in FormEngine again

Oli Bartsch CR +2 V +2 Easy +17 −6 updated 10/22/24, 20:10

Commit message

It's possible to define a hidden input field
in FormEngine, which will be set to '1' when
the form is submitted, e.g. with a *save*
button. Therefore the "doSaveFieldName" option
of the `$resultArray` can be used.

This option is now respected again by
passing it to the FormEngine component.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 913

  1. Oli Bartsch uploaded patch set 1 06/27/24, 13:25

  2. Oli Bartsch updated the commit message in patch set 2 06/27/24, 13:29

  3. Oli Bartsch updated the commit message in patch set 3 06/27/24, 13:29

  4. core-ci voted on patch set 3 V +1 06/27/24, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60463

  5. Benni Mack updated the commit message in patch set 4 V +1 10/18/24, 13:36

  6. core-ci voted on patch set 4 V -1 10/18/24, 22:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68001

  7. core-ci commented on patch set 4 10/19/24, 08:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68001

  8. Oli Bartsch uploaded patch set 5 V -1 10/20/24, 08:39

  9. core-ci voted on patch set 5 V +1 10/20/24, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68253

  10. Andreas Kienast voted on patch set 5 CR +1 V +1 10/22/24, 07:59

  11. Christian Kuhn voted on patch set 5 CR +1 V +1 10/22/24, 16:05

  12. Oli Bartsch voted on patch set 5 CR +2 V +2 10/22/24, 20:10

  13. Oli Bartsch merged patch set 6 10/22/24, 20:10