Review main Merged

84947[BUGFIX] Include scheduled records in BE/CLI/Install applications

Benni Mack CR +2 V +2 Easy +4 −7 updated 07/12/24, 21:35

Commit message

12.0 allowed the option to show "scheduled records",
that is: Records that are timed with starttime / endtime.

However, the backend should always show records (based
on the Context) with starttime / endtime ignored, but
that was simply forgotten in the original patch.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 810

  1. Benni Mack uploaded patch set 1 06/27/24, 18:53

  2. core-ci voted on patch set 1 V +1 06/27/24, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60483

  3. Christian Kuhn commented on patch set 1 06/27/24, 19:02

    yes. i think i saw that when working on rootlineUtility / refindex, and i think i added a todo for this. let me recheck.
  4. Christian Kuhn uploaded patch set 2 V +1 06/27/24, 19:58

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 06/27/24, 19:59

  6. core-ci voted on patch set 2 V +1 06/27/24, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60488

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 06/27/24, 20:07

  8. Benni Mack voted on patch set 2 CR +2 V +2 06/27/24, 20:10

  9. Benni Mack merged patch set 3 06/27/24, 20:10

  10. Mathias Brodala commented on patch set 3 06/28/24, 06:48

    Application.php:56 Unresolved

    So we still don't want to have named arguments? Just from looking at this I have not the slightest idea what this means.