Review main Merged

84976[TASK] Avoid implicitly nullable class method parameter in `EXT:form`

Stefan Bürk CR +2 V +2 Normal +31 −31 updated 06/28/24, 07:27

Commit message

With PHP 8.4 marking method parameter implicitly nullable
is deprecated and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator or adding a null
tyype to an union type definition. [1]

This prepares the way towards PHP 8.4 compatibility.

[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 56

  1. Stefan Bürk uploaded patch set 1 06/27/24, 21:19

  2. core-ci voted on patch set 1 V +1 06/27/24, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60505

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 06/28/24, 00:14

  4. Oliver Klee voted on patch set 1 CR +1 V +1 06/28/24, 07:22

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 06/28/24, 07:26

  6. Stefan Bürk merged patch set 2 06/28/24, 07:27