Review main Merged

84982[TASK] Free DH::__construct() from stateful dependencies

Christian Kuhn CR +2 V +2 Easy +20 −21 updated 06/28/24, 08:35

Commit message

ReferenceIndexUpdater as established with #92356 is
a stateful object designed to "gather" refindex update
jobs and perform them in DH "outer most instance".

An object like this is not something that should be
injectable via DI, but should be hand over at runtime.

DataHandler already has a (clumsy) solution to hand
over state: method start(). The patch switches from
handing ReferenceIndexUpdater over as constructor
argument to start() instead.

This essentially frees DH::__construct() for DI, which
is a great benefit for this class and will be used
with further patches.

Note DH tends to create 'sub instances'. API calls
work on the 'outer most instance' only. The patch
is not considered breaking since the API of 'outer
most instance' does not change: The additional
argument to start() is optional, and used only
internally for sub instances.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1014

  1. Christian Kuhn uploaded patch set 1 06/27/24, 22:59

  2. Christian Kuhn uploaded patch set 2 06/27/24, 23:03

  3. core-ci voted on patch set 1 V -1 06/27/24, 23:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60513

  4. core-ci voted on patch set 2 V +1 06/27/24, 23:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60514

  5. Christian Kuhn updated the commit message in patch set 3 V +1 06/27/24, 23:17

  6. core-ci voted on patch set 3 V +1 06/27/24, 23:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60515

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 06/27/24, 23:46

  8. Christian Kuhn updated the commit message in patch set 4 CR +1 V +1 06/27/24, 23:50

  9. Stefan Bürk voted on patch set 4 CR +1 V +1 06/27/24, 23:51

  10. core-ci voted on patch set 4 V +1 06/27/24, 23:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60517

  11. Oliver Klee voted on patch set 4 CR +1 06/28/24, 07:24

  12. Oli Bartsch voted on patch set 4 CR +1 V +1 06/28/24, 08:18

  13. Christian Kuhn voted on patch set 4 CR +2 V +2 06/28/24, 08:35

  14. Christian Kuhn merged patch set 5 06/28/24, 08:35