Review main Merged

84983[TASK] Free DataMapProcessor for DI

Christian Kuhn CR +2 V +2 Easy +9 −29 updated 06/28/24, 08:35

Commit message

Get more state in DH periphery right: DataMapProcessor
is an `@internal` construct of DataHandler. It has a
static instance() method, used once. The patch removes
__construct() with it's current arguments to free it
towards DI in upcoming patches. State is set
explicitly after object instantiation. Note
ReferenceIndexUpdater is no longer optional.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 710

  1. Christian Kuhn uploaded patch set 1 06/27/24, 23:44

  2. core-ci voted on patch set 1 V +1 06/27/24, 23:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60516

  3. Christian Kuhn updated the commit message in patch set 2 V +1 06/27/24, 23:55

  4. Stefan Bürk updated the commit message in patch set 3 06/27/24, 23:59

  5. Stefan Bürk voted on patch set 3 CR +1 V +1 06/27/24, 23:59

  6. core-ci voted on patch set 2 V +1 06/28/24, 00:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60518

  7. core-ci voted on patch set 3 V +1 06/28/24, 00:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60519

  8. Oli Bartsch voted on patch set 3 CR +1 V +1 06/28/24, 08:20

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 06/28/24, 08:35

  10. Christian Kuhn merged patch set 4 06/28/24, 08:35