Review main Merged

84985[TASK] Make PagePermissionAssembler stateless

Christian Kuhn CR +2 V +2 Normal +21 −54 updated 06/28/24, 12:19

Commit message

PagePermissionAssembler is a DataHandler related
helper that calculates the permission fields of
page records.

The patch removes pollution of __construct() by
manual arguments: $GLOBALS['TYPO3_CONF_VARS'] is
runtime static and can just be used when needed.
This avoids a class property, making the class
stateless.

Minor further clean ups, an improved comment, and
an @todo that we should consider changing the API.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Christian Kuhn uploaded patch set 1 06/28/24, 10:00

  2. core-ci voted on patch set 1 V +1 06/28/24, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60545

  3. Christian Kuhn uploaded patch set 2 V +1 06/28/24, 11:31

  4. Christian Kuhn uploaded patch set 3 06/28/24, 11:43

  5. core-ci voted on patch set 2 V +1 06/28/24, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60551

  6. core-ci voted on patch set 3 V +1 06/28/24, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60556

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 06/28/24, 11:54

  8. Oli Bartsch voted on patch set 3 CR +1 V +1 06/28/24, 11:54

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 06/28/24, 12:19

  10. Christian Kuhn merged patch set 4 06/28/24, 12:19