Review main Merged

84993[TASK] Use DI in DataHandler

Christian Kuhn CR +2 V +2 Hard +189 −151 updated 06/28/24, 18:08

Commit message

DataHandler is now DI aware and gets a bunch of
services injected.

We're not injecting any potentially possible
service blindly - we're omitting stateful ones,
and declare some common classes readonly
along the way to make this more clear.

The DataHandler unit test receives a slightly
bigger update to deal with this properly.

This needs a raise of TF, which had a
`new DataHandler()` in one place:

> composer u typo3/testing-framework

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 4

Files 8

Review log 1220

  1. Christian Kuhn uploaded patch set 1 06/28/24, 12:53

  2. core-ci voted on patch set 1 V -1 06/28/24, 13:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60561

  3. Christian Kuhn uploaded patch set 2 V -1 06/28/24, 13:18

  4. core-ci voted on patch set 2 V -1 06/28/24, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60564

  5. Christian Kuhn uploaded patch set 3 V -1 06/28/24, 13:59

  6. core-ci voted on patch set 3 V -1 06/28/24, 14:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60567

  7. Christian Kuhn uploaded patch set 4 V -1 06/28/24, 14:34

  8. core-ci voted on patch set 4 V -1 06/28/24, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60572

  9. Christian Kuhn uploaded patch set 5 V -1 06/28/24, 15:55

  10. core-ci voted on patch set 5 V +1 06/28/24, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60574

  11. Christian Kuhn uploaded patch set 6 V +1 06/28/24, 16:37

  12. Christian Kuhn uploaded patch set 7 06/28/24, 16:38

  13. core-ci voted on patch set 6 V -1 06/28/24, 16:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60576

  14. core-ci voted on patch set 7 V +1 06/28/24, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60577

  15. Oliver Klee updated the commit message in patch set 8 V +1 06/28/24, 16:45

  16. core-ci voted on patch set 8 V +1 06/28/24, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60578

  17. Stefan Bürk voted on patch set 8 CR +1 V +1 06/28/24, 17:02

  18. Benni Mack voted on patch set 8 CR +1 V +1 06/28/24, 17:27

  19. Christian Kuhn voted on patch set 8 CR +2 V +2 06/28/24, 18:08

  20. Christian Kuhn merged patch set 9 06/28/24, 18:08