85000[BUGFIX] Adapt ObjectConverter test with new symfony/property-info
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1521
-
Torben Hansen uploaded patch set 1 06/28/24, 17:28
-
Torben Hansen updated the commit message in patch set 2 06/28/24, 17:29
-
core-ci voted on patch set 1 V -1 06/28/24, 17:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60579
-
core-ci voted on patch set 2 V -1 06/28/24, 17:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60580
-
Torben Hansen uploaded patch set 3
V -106/28/24, 17:46 -
core-ci voted on patch set 3 V +1 06/28/24, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60581
-
Simon Schaufelberger voted on patch set 3 CR +1 06/28/24, 17:54
-
Christian Kuhn uploaded patch set 4
CR +1V +106/28/24, 17:56 -
Christian Kuhn uploaded patch set 5 06/28/24, 17:58
-
core-ci voted on patch set 4 V -1 06/28/24, 18:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60582
-
Garvin Hicking commented on patch set 5 06/28/24, 18:00
thanks for investigating this so quickly!ObjectConverterTest.php:144Could you add a note to this class mentioning the need gor a FQCN here, so that it might not get accidentally "optimized" by an IDE and not noticed? maybe even add a phpstorm annotation to suppress the inspection suggesiting it (unless this is frowned upon due to being IDE specific)...? -
Christian Kuhn updated the commit message in patch set 6 06/28/24, 18:00
-
Christian Kuhn commented on patch set 6 06/28/24, 18:01
ObjectConverterTest.php:144Replynot needed since tests would then fail ;) -
Christian Kuhn uploaded patch set 7 06/28/24, 18:07
-
Stefan Bürk voted on patch set 7 CR +1 V +1 06/28/24, 18:19
-
Christian Kuhn commented on patch set 7 CR -1 06/28/24, 18:19
nightlies running, currently. -
core-ci voted on patch set 7 V +1 06/28/24, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60586
-
core-ci commented on patch set 7 06/28/24, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60587
-
Christian Kuhn voted on patch set 7 CR +2 V +2 06/28/24, 18:28
-
Simon Schaufelberger voted on patch set 7 CR +1 V +1 06/28/24, 18:28
-
Christian Kuhn merged patch set 8 06/28/24, 18:54