Review main Merged

85000[BUGFIX] Adapt ObjectConverter test with new symfony/property-info

Torben Hansen CR +2 V +2 Normal +70 −8 updated 06/28/24, 18:54

Commit message

With symfony property-info 7.1.2, the type resolving for
collections has been hardened.

https://github.com/symfony/property-info/commit/d0bbc495f11ab99a1e2cbf04699331b88b3c1293

Our extbase ObjectConverter test for collections uses an anonymous
class with an ObjectStorage property. The annotation for the property
as well as the native property type is however not a FQCN. So the
anonymous class has no information about, what FQCN the
`ObjectStorage` class is.

The change adds the FQCN for the ObjectStorage in the
anonymous class, which resolves the failing test, and
adds a test with a non-anymous class to test short
namespaces still work.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1521

  1. Torben Hansen uploaded patch set 1 06/28/24, 17:28

  2. Torben Hansen updated the commit message in patch set 2 06/28/24, 17:29

  3. core-ci voted on patch set 1 V -1 06/28/24, 17:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60579

  4. core-ci voted on patch set 2 V -1 06/28/24, 17:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60580

  5. Torben Hansen uploaded patch set 3 V -1 06/28/24, 17:46

  6. core-ci voted on patch set 3 V +1 06/28/24, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60581

  7. Simon Schaufelberger voted on patch set 3 CR +1 06/28/24, 17:54

  8. Christian Kuhn uploaded patch set 4 CR +1 V +1 06/28/24, 17:56

  9. Christian Kuhn uploaded patch set 5 06/28/24, 17:58

  10. core-ci voted on patch set 4 V -1 06/28/24, 18:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60582

  11. Garvin Hicking commented on patch set 5 06/28/24, 18:00

    thanks for investigating this so quickly!

    ObjectConverterTest.php:144

    Could you add a note to this class mentioning the need gor a FQCN here, so that it might not get accidentally "optimized" by an IDE and not noticed? maybe even add a phpstorm annotation to suppress the inspection suggesiting it (unless this is frowned upon due to being IDE specific)...?
  12. Christian Kuhn updated the commit message in patch set 6 06/28/24, 18:00

  13. Christian Kuhn commented on patch set 6 06/28/24, 18:01

    ObjectConverterTest.php:144 Reply

    not needed since tests would then fail ;)
  14. Christian Kuhn uploaded patch set 7 06/28/24, 18:07

  15. Stefan Bürk voted on patch set 7 CR +1 V +1 06/28/24, 18:19

  16. Christian Kuhn commented on patch set 7 CR -1 06/28/24, 18:19

    nightlies running, currently.
  17. core-ci voted on patch set 7 V +1 06/28/24, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60586

  18. core-ci commented on patch set 7 06/28/24, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60587

  19. Christian Kuhn voted on patch set 7 CR +2 V +2 06/28/24, 18:28

  20. Simon Schaufelberger voted on patch set 7 CR +1 V +1 06/28/24, 18:28

  21. Christian Kuhn merged patch set 8 06/28/24, 18:54