Review 12.4 Merged

85001[BUGFIX] Adapt ObjectConverter test with new symfony/property-info

Christian Kuhn CR +2 V +2 Normal +70 −8 updated 06/28/24, 18:55

Commit message

With symfony property-info 7.1.2, the type resolving for
collections has been hardened.

https://github.com/symfony/property-info/commit/d0bbc495f11ab99a1e2cbf04699331b88b3c1293

Our extbase ObjectConverter test for collections uses an anonymous
class with an ObjectStorage property. The annotation for the property
as well as the native property type is however not a FQCN. So the
anonymous class has no information about, what FQCN the
`ObjectStorage` class is.

The change adds the FQCN for the ObjectStorage in the
anonymous class, which resolves the failing test, and
adds a test with a non-anymous class to test short
namespaces still work.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 36

  1. Christian Kuhn uploaded patch set 1 06/28/24, 18:24

  2. core-ci voted on patch set 1 V +1 06/28/24, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60590

  3. core-ci voted on patch set 1 V -1 06/28/24, 18:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60591

  4. core-ci voted on patch set 1 V +1 06/28/24, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60591

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 06/28/24, 18:55

  6. Christian Kuhn merged patch set 2 06/28/24, 18:55