Review main Merged

85003[TASK] Insert multiple rows when updating refindex

Christian Kuhn CR +2 V +2 Easy +7 −5 updated 06/29/24, 00:00

Commit message

A rather small change to insert all relation rows
at once per handled source row. This gives the
database options to optimize insert operations,
reduces network overhead and number of queries.

My tiny dev setup on an empty sys_refindex table
with a local DB gives a performance gain of
about 5% with referenceindex:update, other
instances will vary, but it won't be slower.

This is good especially with first v13 instance
upgrade, since refindex basically needs a full
rebuild on first run due to the recently
introduces new fields.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 06/28/24, 21:58

  2. core-ci voted on patch set 1 V +1 06/28/24, 22:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60602

  3. Christian Kuhn uploaded patch set 2 V +1 06/28/24, 22:17

  4. core-ci voted on patch set 2 V +1 06/28/24, 22:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60603

  5. Garvin Hicking commented on patch set 2 CR +1 V +1 06/28/24, 23:41

    - $relation['_ACTION'] = 'VOTED';
  6. Stefan Bürk voted on patch set 2 CR +1 V +1 06/28/24, 23:52

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 06/29/24, 00:00

  8. Christian Kuhn merged patch set 3 06/29/24, 00:00