Review main Merged

85007[TASK] Ensure `BIGINT AUTO_INCREMENT PRIMARY KEY` works

Stefan Bürk CR +2 V +2 Easy +34 −0 updated 06/29/24, 00:29

Commit message

This change adds a test to ensure that an
`BIGINT AUTO_INCREMENT PRIMARY KEY` field
works across all databases up to the lowest
maximal value across all databases:

    POSTGRES INTEGER 9223372036854775807

TYPO3 SQL Parser is tested also with this
test along with the Doctrine DBAL baked
database migration.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 58

  1. Stefan Bürk uploaded patch set 1 06/28/24, 23:59

  2. core-ci voted on patch set 1 V +1 06/29/24, 00:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60609

  3. Stefan Bürk uploaded patch set 2 V +1 06/29/24, 00:10

  4. core-ci voted on patch set 2 V +1 06/29/24, 00:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60610

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 06/29/24, 00:19

  6. core-ci commented on patch set 2 06/29/24, 00:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60611

  7. Stefan Bürk commented on patch set 2 CR +2 V +2 06/29/24, 00:29

    Merging due to only test related, hope it's okay to miss a second vote on that.
  8. Stefan Bürk merged patch set 3 06/29/24, 00:29