Review main Merged

85008[TASK] Use TcaSchema in ReferenceIndex

Christian Kuhn CR +2 V +2 Hard +145 −153 updated 07/11/24, 19:43

Commit message

Avoid $GLOBALS['TCA'] access in ReferenceIndex
by using TcaSchema. This is a patch to learn
about fiddly areas and pitfalls when using
TcaSchema in scenarios with lots of different
field related details and relations: The
general API feels good, but it's sensitive
to errors with such transition patches.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1934

Show 59 earlier messages
  1. Christian Kuhn uploaded patch set 1 06/29/24, 00:50

  2. Christian Kuhn rebased onto patch set 2 06/29/24, 00:50

  3. core-ci voted on patch set 1 V +1 06/29/24, 00:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60612

  4. core-ci voted on patch set 2 V +1 06/29/24, 00:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60613

  5. Christian Kuhn uploaded patch set 3 V +1 07/09/24, 10:39

  6. core-ci voted on patch set 3 V -1 07/09/24, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61221

  7. Christian Kuhn uploaded patch set 4 V -1 07/09/24, 11:01

  8. core-ci voted on patch set 4 V -1 07/09/24, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61224

  9. Christian Kuhn uploaded patch set 5 V -1 07/11/24, 10:57

  1. core-ci voted on patch set 5 V -1 07/11/24, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61374

  2. Christian Kuhn uploaded patch set 6 V -1 07/11/24, 11:08

  3. core-ci voted on patch set 6 V -1 07/11/24, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61375

  4. Christian Kuhn uploaded patch set 7 V -1 07/11/24, 11:44

  5. core-ci voted on patch set 7 V -1 07/11/24, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61376

  6. Christian Kuhn uploaded patch set 8 V -1 07/11/24, 12:42

  7. Christian Kuhn uploaded patch set 9 07/11/24, 12:49

  8. core-ci voted on patch set 8 V +1 07/11/24, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61386

  9. Christian Kuhn uploaded patch set 10 07/11/24, 12:51

  10. core-ci voted on patch set 9 V +1 07/11/24, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61387

  11. core-ci voted on patch set 10 V +1 07/11/24, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61388

  12. Christian Kuhn uploaded patch set 11 V +1 07/11/24, 13:11

  13. core-ci voted on patch set 11 V -1 07/11/24, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61389

  14. Christian Kuhn uploaded patch set 12 V -1 07/11/24, 13:22

  15. core-ci voted on patch set 12 V +1 07/11/24, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61390

  16. Christian Kuhn uploaded patch set 13 V +1 07/11/24, 14:01

  17. core-ci voted on patch set 13 V +1 07/11/24, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61392

  18. Christian Kuhn updated the commit message in patch set 14 V +1 07/11/24, 14:12

  19. core-ci voted on patch set 14 V +1 07/11/24, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61394

  20. Christian Kuhn uploaded patch set 15 V +1 07/11/24, 18:52

  21. core-ci voted on patch set 15 V +1 07/11/24, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61408

  22. Benni Mack voted on patch set 15 CR +1 V +1 07/11/24, 19:24

  23. Stefan Bürk voted on patch set 15 CR +1 V +1 07/11/24, 19:31

  24. Christian Kuhn voted on patch set 15 CR +2 V +2 07/11/24, 19:43

  25. Christian Kuhn merged patch set 16 07/11/24, 19:43