85014[TASK] Avoid implicitly nullable class method parameter in `EXT:dashboard`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 810
-
Stefan Bürk uploaded patch set 1 06/29/24, 20:39
-
core-ci voted on patch set 1 V +1 06/29/24, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60635
-
Oliver Klee voted on patch set 1 CR +1 V +1 06/29/24, 20:59
-
Mogens Fiebrandt commented on patch set 1 CR -1 06/30/24, 09:30
ServiceProvider.php:171I think the nullable operator also should be added here -
Stefan Bürk uploaded patch set 2
CR +1V +106/30/24, 12:28 -
Stefan Bürk commented on patch set 2 06/30/24, 12:30
ServiceProvider.php:152ReplyAdded `|null` to phpdocblock. Done.ServiceProvider.php:171ReplyAdded `|null` to phpdocblock. Done. -
core-ci voted on patch set 2 V +1 06/30/24, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60675
-
Oliver Klee voted on patch set 2 CR +1 V +1 06/30/24, 12:45
-
Stefan Bürk voted on patch set 2 CR +2 V +2 06/30/24, 15:31
-
Stefan Bürk merged patch set 3 06/30/24, 15:31
ServiceProvider.php:152