85015[TASK] Avoid implicitly nullable class method parameter in `EXT:dashboard`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Mogens Fiebrandt +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Mogens Fiebrandt +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1215
-
Stefan Bürk uploaded patch set 1 06/29/24, 20:42
-
core-ci voted on patch set 1 V +1 06/29/24, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60636
-
Oliver Klee voted on patch set 1 CR +1 V +1 06/29/24, 21:00
-
Mogens Fiebrandt commented on patch set 1 CR -1 06/30/24, 09:27
-
Stefan Bürk uploaded patch set 2
CR +1V +106/30/24, 12:29 -
Stefan Bürk commented on patch set 2 06/30/24, 12:31
ServiceProvider.php:161ReplyAdded `|null` to phpdocblock. Done. -
core-ci voted on patch set 2 V +1 06/30/24, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60676
-
Oliver Klee commented on patch set 2 V +1 06/30/24, 12:45
ServiceProvider.php:183This then also should be `string|null`. -
Christian Kuhn commented on patch set 3
V +106/30/24, 13:06Published edit on patch set 2. -
Christian Kuhn commented on patch set 3 06/30/24, 13:06
ServiceProvider.php:183ReplyDone -
core-ci voted on patch set 3 V +1 06/30/24, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60684
-
Oliver Klee voted on patch set 3 CR +1 V +1 06/30/24, 15:21
-
Mogens Fiebrandt voted on patch set 3 CR +1 V +1 06/30/24, 15:25
-
Stefan Bürk voted on patch set 3 CR +2 V +2 06/30/24, 15:31
-
Stefan Bürk merged patch set 4 06/30/24, 15:31
ServiceProvider.php:161