Review 11.5 Merged

85015[TASK] Avoid implicitly nullable class method parameter in `EXT:dashboard`

Stefan Bürk CR +2 V +2 Easy +6 −6 updated 06/30/24, 15:31

Commit message

With PHP 8.4 marking method parameter implicitly nullable
is deprecated and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator or adding a null
type to an union type definition. [1]

This prepares the way towards PHP 8.4 compatibility.

[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Mogens Fiebrandt +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Mogens Fiebrandt +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Stefan Bürk uploaded patch set 1 06/29/24, 20:42

  2. core-ci voted on patch set 1 V +1 06/29/24, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60636

  3. Oliver Klee voted on patch set 1 CR +1 V +1 06/29/24, 21:00

  4. Mogens Fiebrandt commented on patch set 1 CR -1 06/30/24, 09:27

    ServiceProvider.php:161

    I think the nullable operator also should be added here.
  5. Stefan Bürk uploaded patch set 2 CR +1 V +1 06/30/24, 12:29

  6. Stefan Bürk commented on patch set 2 06/30/24, 12:31

    ServiceProvider.php:161 Reply

    Added `|null` to phpdocblock. Done.
  7. core-ci voted on patch set 2 V +1 06/30/24, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60676

  8. Oliver Klee commented on patch set 2 V +1 06/30/24, 12:45

    ServiceProvider.php:183

    This then also should be `string|null`.
  9. Christian Kuhn commented on patch set 3 V +1 06/30/24, 13:06

    Published edit on patch set 2.
  10. Christian Kuhn commented on patch set 3 06/30/24, 13:06

    ServiceProvider.php:183 Reply

    Done
  11. core-ci voted on patch set 3 V +1 06/30/24, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60684

  12. Oliver Klee voted on patch set 3 CR +1 V +1 06/30/24, 15:21

  13. Mogens Fiebrandt voted on patch set 3 CR +1 V +1 06/30/24, 15:25

  14. Stefan Bürk voted on patch set 3 CR +2 V +2 06/30/24, 15:31

  15. Stefan Bürk merged patch set 4 06/30/24, 15:31