85021[TASK] Avoid implicitly nullable class method parameter in `EXT:belog`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
-
Verified V +2 Done
- Stefan Bürk +2
- core-ci +1 CI
Issues 1
Files 3
Review log 911
-
Stefan Bürk uploaded patch set 1 06/29/24, 20:54
-
core-ci voted on patch set 1 V +1 06/29/24, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60642
-
Oliver Klee voted on patch set 1 CR +1 V +1 06/29/24, 21:13
-
Mogens Fiebrandt commented on patch set 1 CR -1 06/30/24, 09:17
-
Mogens Fiebrandt commented on patch set 1 06/30/24, 09:18
Constraint.php:276I think the nullable operator should be added here. -
Stefan Bürk uploaded patch set 2
CR +1V +106/30/24, 12:12 -
Stefan Bürk commented on patch set 2 06/30/24, 12:12
Constraint.php:276Replyack, updated. -
Stefan Bürk commented on patch set 2 06/30/24, 12:15
SystemInformationController.php:36ReplyNope. this will be set to an array in the constructor in any case, so this is correct (and was already). -
core-ci voted on patch set 2 V +1 06/30/24, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60672
-
Stefan Bürk voted on patch set 2 CR +2 V +2 06/30/24, 12:22
-
Stefan Bürk merged patch set 3 06/30/24, 12:22
SystemInformationController.php:36