Review 11.5 Merged

85021[TASK] Avoid implicitly nullable class method parameter in `EXT:belog`

Stefan Bürk CR +2 V +2 Easy +5 −5 updated 06/30/24, 12:22

Commit message

With PHP 8.4 marking method parameter implicitly nullable
is deprecated and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator or adding a null
type to an union type definition. [1]

This prepares the way towards PHP 8.4 compatibility.

[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Stefan Bürk uploaded patch set 1 06/29/24, 20:54

  2. core-ci voted on patch set 1 V +1 06/29/24, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60642

  3. Oliver Klee voted on patch set 1 CR +1 V +1 06/29/24, 21:13

  4. Mogens Fiebrandt commented on patch set 1 CR -1 06/30/24, 09:17

    SystemInformationController.php:36

    I think the nullable operator also should be added here. Or maybe remove the annotation and add the type to the variable declaration.
  5. Mogens Fiebrandt commented on patch set 1 06/30/24, 09:18

    Constraint.php:276

    I think the nullable operator should be added here.
  6. Stefan Bürk uploaded patch set 2 CR +1 V +1 06/30/24, 12:12

  7. Stefan Bürk commented on patch set 2 06/30/24, 12:12

    Constraint.php:276 Reply

    ack, updated.
  8. Stefan Bürk commented on patch set 2 06/30/24, 12:15

    SystemInformationController.php:36 Reply

    Nope. this will be set to an array in the constructor in any case, so this is correct (and was already).
  9. core-ci voted on patch set 2 V +1 06/30/24, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60672

  10. Stefan Bürk voted on patch set 2 CR +2 V +2 06/30/24, 12:22

  11. Stefan Bürk merged patch set 3 06/30/24, 12:22