Review 11.5 Merged

85024[TASK] Avoid implicitly nullable class method parameter in `EXT:adminpanel`

Stefan Bürk CR +2 V +2 Easy +5 −14 updated 06/30/24, 12:10

Commit message

With PHP 8.4 marking method parameter implicitly nullable
is deprecated and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator or adding a null
type to an union type definition. [1]

This prepares the way towards PHP 8.4 compatibility.

[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Stefan Bürk uploaded patch set 1 06/29/24, 21:00

  2. core-ci voted on patch set 1 V +1 06/29/24, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60645

  3. Oliver Klee voted on patch set 1 CR +1 V +1 06/29/24, 21:13

  4. Mogens Fiebrandt commented on patch set 1 CR -1 06/29/24, 22:14

    AjaxController.php:51

    I think either the params has to be removed from the annotations or the nullable operator also has to be set there.

    MainController.php:75

    I think either the params has to be removed from the annotations or the nullable operator also has to be set there.
  5. Stefan Bürk uploaded patch set 2 CR +1 V +1 06/30/24, 12:01

  6. Stefan Bürk commented on patch set 2 06/30/24, 12:02

    AjaxController.php:51 Reply

    ack. removed.

    MainController.php:75 Reply

    ack. removed.
  7. core-ci voted on patch set 2 V +1 06/30/24, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60670

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 06/30/24, 12:10

  9. Stefan Bürk merged patch set 3 06/30/24, 12:10