85024[TASK] Avoid implicitly nullable class method parameter in `EXT:adminpanel`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
-
Verified V +2 Done
- Stefan Bürk +2
- core-ci +1 CI
Issues 1
Files 3
Review log 79
-
Stefan Bürk uploaded patch set 1 06/29/24, 21:00
-
core-ci voted on patch set 1 V +1 06/29/24, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60645
-
Oliver Klee voted on patch set 1 CR +1 V +1 06/29/24, 21:13
-
Mogens Fiebrandt commented on patch set 1 CR -1 06/29/24, 22:14
MainController.php:75I think either the params has to be removed from the annotations or the nullable operator also has to be set there. -
Stefan Bürk uploaded patch set 2
CR +1V +106/30/24, 12:01 -
Stefan Bürk commented on patch set 2 06/30/24, 12:02
AjaxController.php:51Replyack. removed.MainController.php:75Replyack. removed. -
core-ci voted on patch set 2 V +1 06/30/24, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60670
-
Stefan Bürk voted on patch set 2 CR +2 V +2 06/30/24, 12:10
-
Stefan Bürk merged patch set 3 06/30/24, 12:10
AjaxController.php:51