Review main Merged

85026[TASK] Have more DI in FlexFormTools

Christian Kuhn CR +2 V +2 Normal +62 −101 updated 06/30/24, 12:23

Commit message

FlexFormTools is a stateless service since #102229.
The - also stateless - TcaMigration dependency is
now injected. Get the service injected more often
and adapt a few tests to deal with this.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 710

  1. Christian Kuhn uploaded patch set 1 06/30/24, 10:10

  2. core-ci voted on patch set 1 V -1 06/30/24, 10:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60661

  3. Christian Kuhn uploaded patch set 2 V -1 06/30/24, 11:26

  4. Christian Kuhn updated the commit message in patch set 3 06/30/24, 11:27

  5. core-ci voted on patch set 2 V +1 06/30/24, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60666

  6. core-ci voted on patch set 3 V +1 06/30/24, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60667

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 06/30/24, 11:39

  8. Andreas Nedbal voted on patch set 3 CR +1 V +1 06/30/24, 12:22

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 06/30/24, 12:23

  10. Christian Kuhn merged patch set 4 06/30/24, 12:23