Review 11.5 Merged

85028[TASK] Avoid implicitly nullable class method parameter in `EXT:fluid`

Stefan Bürk CR +2 V +2 Easy +2 −3 updated 07/01/24, 06:24

Commit message

With PHP 8.4 marking method parameter implicitly nullable
is deprecated and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator or adding a null
type to an union type definition. [1]

This prepares the way towards PHP 8.4 compatibility.

[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Mogens Fiebrandt +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Mogens Fiebrandt +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Stefan Bürk uploaded patch set 1 06/30/24, 12:41

  2. Oliver Klee voted on patch set 1 CR +1 06/30/24, 12:46

  3. core-ci voted on patch set 1 V +1 06/30/24, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60677

  4. Oliver Klee voted on patch set 1 V +1 06/30/24, 12:52

  5. Mogens Fiebrandt voted on patch set 1 CR +1 V +1 06/30/24, 23:42

  6. Georg Ringer voted on patch set 1 CR +2 V +2 07/01/24, 06:24

  7. Georg Ringer merged patch set 2 07/01/24, 06:24