Review main Merged

85032[TASK] Avoid MockEventDispatcher

Christian Kuhn CR +2 V +2 Normal +32 −130 updated 06/30/24, 14:04

Commit message

The MockEventDispatcher unit test fixture became
useless with introduction of NoopEventDispatcher.

The patch removes last remains: Most simply inject
NoopEventDispatcher, some others create a mock of
EventDispatcherInterface and use it for event
manipulation when testing $subjects that act on
event results.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 56

  1. Christian Kuhn uploaded patch set 1 06/30/24, 13:03

  2. core-ci voted on patch set 1 V +1 06/30/24, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60681

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 06/30/24, 13:11

  4. Anja Leichsenring voted on patch set 1 CR +1 V +1 06/30/24, 13:58

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 06/30/24, 14:04

  6. Stefan Bürk merged patch set 2 06/30/24, 14:04