Review main Merged

85037[TASK] Use TcaPreparation in FlexFormTools

Christian Kuhn CR +2 V +2 Hard +284 −286 updated 07/02/24, 15:34

Commit message

With introduction of new types "category", "file",
"email" and "link", class TcaPreparation has been
established to auto-add TCA details that should
be shadowed-away for devs, and are added internally.

This created quite a mess within FlexFormTools since
TcaPrepration needs to be applied there as well, but
with slightly different "category" and "file" details.

Also, "email" and "link" received some hacks in
runtime code to dynamically add "softref" - a thing
TcaPreparation should handle as well, but didn't,
also due to the hacks in FlexFormTools.

This is an issue in combination with new TcaSchema:
TcaSchemaFactory relies on TCA being "final" and
not changed at runtime.

The patch clean this up:

* Free FlexFormTools from own implementations of
  "category" and "file" fields, call TcaPreparation.
* Align TcaPreparation with the changes for flex
  fields by having a toggle for this and act upon.
* Move "email" and "link" "softref" runtime hacks
  into TcaPreparation.
* Protect a helper method in TcaPreparation
  previously used by FlexFormTools.
* Refactor a double nested closure in TcaPreparation
  towards methods.
* Refactor some tests and add some easy ones for
  "sofref" handling in TcaPreparation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 7

Files 8

Review log 2034

Show 59 earlier messages
  1. Christian Kuhn uploaded patch set 1 06/30/24, 16:14

  2. Christian Kuhn updated the commit message in patch set 2 06/30/24, 16:14

  3. core-ci voted on patch set 1 V -1 06/30/24, 16:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60702

  4. core-ci voted on patch set 2 V -1 06/30/24, 16:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60703

  5. Christian Kuhn uploaded patch set 3 V -1 06/30/24, 16:37

  6. core-ci voted on patch set 3 V -1 06/30/24, 16:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60704

  7. Christian Kuhn uploaded patch set 4 V -1 07/01/24, 10:33

  8. core-ci voted on patch set 4 V -1 07/01/24, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60761

  9. Christian Kuhn uploaded patch set 5 V -1 07/01/24, 12:34

  1. core-ci voted on patch set 5 V -1 07/01/24, 12:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60772

  2. Christian Kuhn uploaded patch set 6 V -1 07/01/24, 14:55

  3. core-ci voted on patch set 6 V -1 07/01/24, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60780

  4. Christian Kuhn rebased onto patch set 7 V -1 07/01/24, 15:56

  5. core-ci voted on patch set 7 V -1 07/01/24, 16:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60786

  6. Christian Kuhn uploaded patch set 8 V -1 07/01/24, 16:54

  7. core-ci voted on patch set 8 V -1 07/01/24, 17:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60787

  8. Christian Kuhn uploaded patch set 9 V -1 07/01/24, 17:09

  9. core-ci voted on patch set 9 V -1 07/01/24, 17:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60788

  10. Christian Kuhn uploaded patch set 10 V -1 07/01/24, 17:16

  11. core-ci voted on patch set 10 V +1 07/01/24, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60789

  12. Christian Kuhn uploaded patch set 11 V +1 07/02/24, 10:18

  13. core-ci voted on patch set 11 V -1 07/02/24, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60828

  14. Christian Kuhn uploaded patch set 12 V -1 07/02/24, 10:26

  15. core-ci voted on patch set 12 V -1 07/02/24, 10:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60829

  16. Christian Kuhn uploaded patch set 13 V -1 07/02/24, 10:48

  17. core-ci voted on patch set 13 V -1 07/02/24, 10:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60833

  18. Christian Kuhn updated the commit message in patch set 14 V -1 07/02/24, 11:08

  19. Christian Kuhn uploaded patch set 15 07/02/24, 11:11

  20. core-ci voted on patch set 15 V +1 07/02/24, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60838

  21. Oli Bartsch commented on patch set 15 CR +1 V +1 07/02/24, 13:19

    TcaPreparation.php:294

    Was not quite sure since override is actually a change in behaviour. However it's not documented as such but isntead there is even a note stating that the softref is automatically applied. Should be fine. Same for type=link, where I added corresponding note, too. (https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-TCA/pull/1079)
  22. Stefan Bürk voted on patch set 15 CR +1 V +1 07/02/24, 15:27

  23. Christian Kuhn commented on patch set 15 07/02/24, 15:27

    TcaPreparation.php:294 Reply

    yes. they are not mentioned in docs as property and hard-applied.
  24. Christian Kuhn voted on patch set 15 CR +2 V +2 07/02/24, 15:34

  25. Christian Kuhn merged patch set 16 07/02/24, 15:34