Review main Merged

85038[TASK] Inherit example color scheme when not set

Benjamin Kott CR +2 V +2 Easy +1 −6 updated 07/01/24, 07:33

Commit message

The styleguide examples were forced into adaptive light dark
mode instead of respecting the current inheritance. We are now
only forcing dedicated modes when the `colorschemes` option of
the CodeViewHelper is set.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Benjamin Kott uploaded patch set 1 07/01/24, 05:29

  2. core-ci voted on patch set 1 V +1 07/01/24, 05:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60724

  3. Georg Ringer voted on patch set 1 CR +1 V +1 07/01/24, 05:51

  4. Oli Bartsch updated the commit message in patch set 2 CR +1 V +1 07/01/24, 06:11

  5. Oli Bartsch voted on patch set 2 CR +1 V +1 07/01/24, 06:11

  6. core-ci voted on patch set 2 V +1 07/01/24, 06:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60725

  7. Andreas Kienast voted on patch set 2 CR +1 V +1 07/01/24, 07:27

  8. Benjamin Kott voted on patch set 2 CR +2 V +2 07/01/24, 07:33

  9. Benjamin Kott merged patch set 3 07/01/24, 07:33