85047[TASK] Use a Identity Map for Record objects
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Oliver Hader +1
- core-ci +1 CI
Issues 2
Files 9
- typo3/sysext/backend/Classes/View/BackendLayout/ContentFetcher.php+3 −2
- typo3/sysext/backend/Classes/View/BackendLayout/RecordRememberer.phpdeleted+0 −49
- typo3/sysext/backend/Classes/View/Drawing/BackendLayoutRenderer.php+9 −4
- typo3/sysext/backend/Classes/View/PageLayoutContext.php+11 −0
- typo3/sysext/backend/Tests/Functional/View/Drawing/BackendLayoutRendererTest.php+10 −10
- typo3/sysext/core/Classes/Domain/Persistence/RecordIdentityMap.php3new+79 −0
- typo3/sysext/core/Classes/Domain/RecordFactory.php+2 −0
- typo3/sysext/frontend/Classes/Content/RecordCollector.php+9 −7
- typo3/sysext/frontend/Classes/DataProcessing/PageContentFetchingProcessor.php+3 −0
Review log 1524
-
Benni Mack uploaded patch set 1 07/01/24, 14:24
-
core-ci voted on patch set 1 V -1 07/01/24, 14:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60775
-
Benni Mack updated the commit message in patch set 2
V -107/01/24, 15:04 -
core-ci voted on patch set 2 V -1 07/01/24, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60782
-
Oliver Hader uploaded patch set 3
V -107/11/24, 16:34 -
core-ci voted on patch set 3 V +1 07/11/24, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61398
-
Oliver Hader uploaded patch set 4
V +107/11/24, 17:03 -
core-ci voted on patch set 4 V +1 07/11/24, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61399
-
Benni Mack uploaded patch set 5
V +107/11/24, 17:34 -
core-ci voted on patch set 5 V +1 07/11/24, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61402
-
Benni Mack uploaded patch set 6 07/11/24, 18:25
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 6 V +1 07/11/24, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61405
-
Christian Kuhn commented on patch set 6 07/11/24, 19:56
RecordIdentityMap.php:64i think be much better if the signature would is: public function findByIdentifier(string $mainType, int $identifier): RecordInterface and public function hasIdentifier(string $mainType, int $identifier): bool reason: we should not have these fallbacks in this class: it is job of the consumer to see if it has a 'valid' record at hand, and to then ask this class for a resolved record? -
Benni Mack rebased onto patch set 7
V +107/11/24, 20:44 -
Benni Mack uploaded patch set 8 07/11/24, 20:48
-
Benni Mack commented on patch set 8 07/11/24, 20:48
RecordIdentityMap.php:64ReplyDone -
core-ci voted on patch set 7 V +1 07/11/24, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61414
-
core-ci voted on patch set 8 V -1 07/11/24, 20:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61416
-
Benni Mack uploaded patch set 9
V -107/11/24, 21:00 -
core-ci voted on patch set 9 V +1 07/11/24, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61417
-
Oliver Hader commented on patch set 9 CR +1 V +1 07/11/24, 22:03
RecordIdentityMap.php:69Exception, phew... Well... let's move on... ;-) -
Christian Kuhn voted on patch set 9 CR +1 V +1 07/11/24, 22:16
-
Benni Mack voted on patch set 9 CR +2 V +2 07/11/24, 22:25
-
Benni Mack merged patch set 10 07/11/24, 22:25