Review main Merged

85050[TASK] Re-establish TcaMigration tests for flex form

Christian Kuhn CR +2 V +2 Hard +249 −161 updated 07/01/24, 15:48

Commit message

TcaMigration for flex form fields lived in FormEngine
related TcaFlexPrepare, and has been moved to
FlexFormTools with #99756.
The related tests were located within UnitDeprecated
since they trigger_error(, E_USER_DEPRECATED). Those
have been later removed with #101115 during v13
deprecation removals. This is bad, we do need to know
if this recursive implemention works.

* Move remaining FormEngine TcaFlexPrepareTest from
  unit to functional tests for simplified maintenance.
* Use DI for TcaItemsProcessorFunctions - a class
  used as TCA 'itemsProcFunc' for special BE cases.
* Add tests of flex form TcaMigration to functional
  FlexFormToolsTests. This is done using a dummy
  error handler to have them within casual (non
  deprecated) tests, which should prevent accidential
  removal in the future.
* Move TcaItemsProcessorFunctionsTest unit tests to
  a functional test case for simplified maintenance.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 79

  1. Christian Kuhn uploaded patch set 1 07/01/24, 15:32

  2. Christian Kuhn updated the commit message in patch set 2 07/01/24, 15:39

  3. core-ci voted on patch set 1 V +1 07/01/24, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60783

  4. Christian Kuhn updated the commit message in patch set 3 07/01/24, 15:40

  5. Benni Mack voted on patch set 3 CR +1 V +1 07/01/24, 15:41

  6. Garvin Hicking voted on patch set 3 CR +1 V +1 07/01/24, 15:44

  7. core-ci voted on patch set 3 V +1 07/01/24, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60785

  8. Christian Kuhn voted on patch set 3 CR +2 V +2 07/01/24, 15:47

  9. Christian Kuhn merged patch set 4 07/01/24, 15:48