85079[FEATURE] Introduce PSR-14 events for RTE/persistence HTML transforms
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stephan Kellermayr +1
-
Verified V +2 Done
- Benni Mack +2
- Stephan Kellermayr +1
- core-ci +1 CI
Issues 2
Files 11
- typo3/sysext/core/Classes/Html/Event/AfterTransformTextForPersistenceEvent.phpnew+51 −0
- typo3/sysext/core/Classes/Html/Event/AfterTransformTextForRichTextEditorEvent.phpnew+51 −0
- typo3/sysext/core/Classes/Html/Event/BeforeTransformTextForPersistenceEvent.phpnew+51 −0
- typo3/sysext/core/Classes/Html/Event/BeforeTransformTextForRichTextEditorEvent.phpnew+51 −0
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+40 −2
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-104221-IntroducePSR14EventsForRteTransformations.rstnew+133 −0
- typo3/sysext/core/Tests/Functional/Html/EventListener/RteHtmlParserTest.phpnew+138 −0
- typo3/sysext/core/Tests/Unit/Html/Event/AfterTransformTextForPersistenceEventTest.phpnew+44 −0
- typo3/sysext/core/Tests/Unit/Html/Event/AfterTransformTextForRichTextEditorEventTest.phpnew+44 −0
- typo3/sysext/core/Tests/Unit/Html/Event/BeforeTransformTextForPersistenceEventTest.phpnew+44 −0
- typo3/sysext/core/Tests/Unit/Html/Event/BeforeTransformTextForRichTextEditorEventTest.phpnew+44 −0
Review log 2129
Show 24 earlier messages
-
Garvin Hicking uploaded patch set 1 07/02/24, 10:05
-
core-ci voted on patch set 1 V -1 07/02/24, 10:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60825
-
Garvin Hicking rebased onto patch set 2
V -107/02/24, 10:15 -
core-ci voted on patch set 2 V -1 07/02/24, 10:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60827
-
Garvin Hicking rebased onto patch set 3
V -107/02/24, 10:51 -
core-ci voted on patch set 3 V +1 07/02/24, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60835
-
Garvin Hicking uploaded patch set 4
V +107/02/24, 11:06Fix typo -
core-ci voted on patch set 4 V +1 07/02/24, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60836
-
Stephan Kellermayr commented on patch set 4 CR +1 V +1 07/02/24, 13:46
Thanks a million for this wonderful code suggestion! -
Stefan Froemken voted on patch set 4 CR +1 07/02/24, 13:56
-
Georg Ringer voted on patch set 4 CR +1 V +1 07/03/24, 05:54
-
Guido Schmechel voted on patch set 4 CR +1 V +1 07/03/24, 22:39
-
Markus Klein voted on patch set 4 CR +1 V +1 07/04/24, 10:55
-
Benni Mack commented on patch set 4 CR -2 07/04/24, 11:46
will review carefully (background: I was the one mainly cleaning up the RteHtmlParser class since TYPO3 v8.0, so I want to ensure that the arguments are properly set) -
Benni Mack commented on patch set 4 07/12/24, 06:00
Hey everyone. here is my take on this change: I recently ran into this issue in v12 where the hooks are now removed. However, can somebody quickly enlighten me why we need the RteHtmlParser instance within the Events? I think we can get rid of them... -
Garvin Hicking commented on patch set 4 07/12/24, 06:22
Reply
My idea here was to make it future proof and provide maximum context. RteHtmlParser carries some state when the event is fired, and I wanted to be able to access it. I don't think it's vital, but I'd rather have it than miss it down the road. I'm fine with either decision. -
Benni Mack updated the commit message in patch set 5
CR +1V +107/12/24, 07:12Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 5 V +1 07/12/24, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61456
-
Benni Mack commented on patch set 5 CR -1 07/12/24, 07:19
Reply
Then let's remove it please. We can add it later-on once we know we need it. -
Benni Mack rebased onto patch set 6
CR -1V +107/12/24, 07:44 -
core-ci voted on patch set 6 V +1 07/12/24, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61459
-
Garvin Hicking uploaded patch set 7
V +107/12/24, 07:55Remove RteHtmlParser instance relation -
core-ci voted on patch set 7 V -1 07/12/24, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61461
-
Garvin Hicking uploaded patch set 8
V -107/12/24, 08:07Fix CGL -
core-ci voted on patch set 8 V +1 07/12/24, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61462
-
Garvin Hicking commented on patch set 8 07/12/24, 08:29
Reply
Done, is it ok like this? -
Stephan Kellermayr commented on patch set 8 CR +1 V +1 07/12/24, 08:51
As far as my project is concerned (complete replacement of entire elements), I am satisfied with both solutions. -
Benni Mack voted on patch set 8 CR +2 V +2 07/12/24, 09:21
-
Benni Mack merged patch set 9 07/12/24, 09:21