Review main Merged

85083[BUGFIX] Prevent multiple FlexContainers of same name

Garvin Hicking CR +2 V +2 Normal +190 −2 updated 07/03/24, 16:20

Commit message

It is possible in Flexform containers to set a XML
configuration that uses the same input field names,
but within different sheets.

The `FlexFormSectionContainer::render()` method used a
HTML DOM id attribute that did not consider
the Flexform sheet name, which has lead to the same id
attribute being re-used. The JavaScript events (add
and delete items from a container) would then
fire only on the first instance, but as many times
as there were wrongly regarded "duplicate" containers
using the same id.

This fix introduces another identifier section to the
id attribute, containing the Flexform sheet name.
This XML attribute is compatible
with allowed CSS class names, so no further escaping is
done with it, similar to the use of `$flexFormFieldName`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 913

  1. Garvin Hicking uploaded patch set 1 07/02/24, 12:40

  2. core-ci voted on patch set 1 V -1 07/02/24, 13:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60840

  3. Garvin Hicking uploaded patch set 2 V -1 07/02/24, 14:24

    Fix TCA migration
  4. core-ci voted on patch set 2 V +1 07/02/24, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60845

  5. Garvin Hicking uploaded patch set 3 V +1 07/03/24, 10:43

    Introduce fix
  6. core-ci voted on patch set 3 V +1 07/03/24, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60901

  7. Garvin Hicking uploaded patch set 4 V +1 07/03/24, 11:04

    Simplify flexform XML
  8. core-ci voted on patch set 4 V +1 07/03/24, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60902

  9. Christian Kuhn voted on patch set 4 CR +1 07/03/24, 11:15

  10. Simon Schaufelberger voted on patch set 4 CR +1 V +1 07/03/24, 13:20

  11. Oli Bartsch voted on patch set 4 CR +1 V +1 07/03/24, 15:05

  12. Oli Bartsch voted on patch set 4 CR +2 V +2 07/03/24, 16:20

  13. Oli Bartsch merged patch set 5 07/03/24, 16:20