Review main Merged

85084[TASK] Move TCA control sanitization to TcaPreparation

Oli Bartsch CR +2 V +2 Hard +240 −246 updated 07/02/24, 16:20

Commit message

The functionality to ensure that system internal
columns that are required for data integrity
are available in case they have been defined
in the TCA control section, was previously
done in TcaMigration.

However, since TcaMigration should only
contain migration functionality, which
on the one hand logs deprecation warnings
and on the other hand get's removed again
after some versions, the corresponding
functionality is now moved to TcaPreparation.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 812

  1. Oli Bartsch uploaded patch set 1 07/02/24, 14:10

  2. Oli Bartsch uploaded patch set 2 07/02/24, 14:12

  3. core-ci voted on patch set 1 V -1 07/02/24, 14:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60843

  4. core-ci voted on patch set 2 V -1 07/02/24, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60844

  5. Oli Bartsch uploaded patch set 3 V -1 07/02/24, 14:33

  6. core-ci voted on patch set 3 V +1 07/02/24, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60848

  7. Christian Kuhn uploaded patch set 4 V +1 07/02/24, 15:59

  8. core-ci voted on patch set 4 V +1 07/02/24, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60850

  9. Christian Kuhn voted on patch set 4 CR +1 V +1 07/02/24, 16:09

  10. Stefan Bürk voted on patch set 4 CR +1 V +1 07/02/24, 16:14

  11. Oli Bartsch voted on patch set 4 CR +2 V +2 07/02/24, 16:20

  12. Oli Bartsch merged patch set 5 07/02/24, 16:20