Review main Abandoned

85085[BUGFIX] Use actual tableName and fieldName for FlexForm TCA migration

Oli Bartsch CR 0 V 0 Easy +13 −13 updated 07/02/24, 16:21

Commit message

Migrating TCA is done via TCAMigration, which
usually logs a deprecation warning for each
performed migration, containing the table and
field name as well as the migrated option / config.

Deprecation warnings for FlexForm migrations
however always contained "dummyTable" and
"dummyField" instead of the actual values,
making it quite hard to find the places, which
need to be adapted.

This is now fixed by using the resolved table
and field names form the parsed identifier.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 68

  1. Oli Bartsch uploaded patch set 1 07/02/24, 14:29

  2. core-ci voted on patch set 1 V +1 07/02/24, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60847

  3. Christian Kuhn commented on patch set 1 07/02/24, 15:53

    FlexFormTools.php:265 Unresolved

    isn't this even more confusing? this will end up being 'tt_content' in many cases, which would indicate a column in tt_content, which it isn't. maybe a hard coded "flexField" or something?
  4. Oli Bartsch uploaded patch set 2 V +1 07/02/24, 16:10

  5. Oli Bartsch uploaded patch set 3 07/02/24, 16:18

  6. Oli Bartsch uploaded patch set 4 07/02/24, 16:18

  7. core-ci voted on patch set 2 V -1 07/02/24, 16:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60851

  8. Oli Bartsch abandoned the change 07/02/24, 16:21

    Searching for a better solution